Skip to content

ci: trigger goreleaser on tag push, create draft release#148

Merged
BakerNet merged 1 commit into
mainfrom
chore/goreleaser-tag-push
Jun 17, 2026
Merged

ci: trigger goreleaser on tag push, create draft release#148
BakerNet merged 1 commit into
mainfrom
chore/goreleaser-tag-push

Conversation

@BakerNet

Copy link
Copy Markdown
Collaborator

Problem

Creating a release draft never triggered the goreleaser action. Two reasons:

  1. The workflow triggered on the release event, but draft releases do not emit release activity events (draft isn't even a valid type; created doesn't fire for draft saves). release events only fire once a release is published.
  2. The config file is named goreleaser.yml (non-standard), and the workflow ran release --clean without --config, so GoReleaser may not have auto-discovered it even if it had triggered.

Change

  • Trigger on tag push (push: tags: ['v*']) instead of the release event. This is GoReleaser's canonical setup.
  • Create the release as a draft (release.draft: true). GoReleaser builds and uploads all artifacts to a draft; you then generate the changelog in the UI (selecting the previous tag) and publish manually. Publishing last is also required for immutable releases, which freeze a release's assets on publish — uploading to an already-published release would fail.
  • Disable GoReleaser's changelog (changelog.disable: true) since notes are generated manually in the UI (GoReleaser's github-native can't pin the previous tag, which is needed for our prerelease/rc tagging).
  • Pass --config goreleaser.yml for the non-standard filename.

Release flow after this

  1. Push a v* tag → workflow runs, GoReleaser creates a draft release with all binaries/checksums attached.
  2. In the UI: Generate release notes, select the previous tag, review.
  3. Publish → release is finalized (and frozen, under immutable releases) with assets intact.

🤖 Generated with Claude Code

@github-actions github-actions Bot requested a review from zbedforrest June 17, 2026 22:28

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the goreleaser.yml configuration to create GitHub releases as drafts and disables automatic changelog generation, allowing for manual changelog creation in the GitHub UI. There are no review comments to address.

@github-actions

Copy link
Copy Markdown

Codeowners approval required for this PR:

@BakerNet BakerNet force-pushed the chore/goreleaser-tag-push branch from e7432b0 to 81b0be3 Compare June 17, 2026 22:29
@BakerNet BakerNet merged commit d8d4c92 into main Jun 17, 2026
7 of 8 checks passed
@BakerNet BakerNet deleted the chore/goreleaser-tag-push branch June 17, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant