ci: trigger goreleaser on tag push, create draft release#148
Merged
Conversation
|
Codeowners approval required for this PR: |
don't trigger GHA release events
e7432b0 to
81b0be3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Creating a release draft never triggered the goreleaser action. Two reasons:
releaseevent, but draft releases do not emitreleaseactivity events (draftisn't even a valid type;createddoesn't fire for draft saves).releaseevents only fire once a release is published.goreleaser.yml(non-standard), and the workflow ranrelease --cleanwithout--config, so GoReleaser may not have auto-discovered it even if it had triggered.Change
push: tags: ['v*']) instead of thereleaseevent. This is GoReleaser's canonical setup.release.draft: true). GoReleaser builds and uploads all artifacts to a draft; you then generate the changelog in the UI (selecting the previous tag) and publish manually. Publishing last is also required for immutable releases, which freeze a release's assets on publish — uploading to an already-published release would fail.changelog.disable: true) since notes are generated manually in the UI (GoReleaser'sgithub-nativecan't pin the previous tag, which is needed for our prerelease/rc tagging).--config goreleaser.ymlfor the non-standard filename.Release flow after this
v*tag → workflow runs, GoReleaser creates a draft release with all binaries/checksums attached.🤖 Generated with Claude Code