Skip to content

adapt tx pool on execution to include info from last execution results#7327

Merged
AdoAdoAdo merged 12 commits into
feat/supernova-async-execfrom
supernova-tx-pool-commit-integration
Oct 23, 2025
Merged

adapt tx pool on execution to include info from last execution results#7327
AdoAdoAdo merged 12 commits into
feat/supernova-async-execfrom
supernova-tx-pool-commit-integration

Conversation

@ssd04

@ssd04 ssd04 commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

Reasoning behind the pull request

  • TxPool state has to be updated on CommitBlock based on last execution results
  • rootHash has to be also set based on last execution results info

Proposed changes

  • Updated OnExecuted method on TxPool to receive also rootHash, which is selected based on Supernova activation

Testing procedure

  • With the feat branch

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@ssd04 ssd04 self-assigned this Oct 9, 2025
Base automatically changed from sync-block-v3 to feat/supernova-async-exec October 15, 2025 12:01
@ssd04 ssd04 marked this pull request as ready for review October 15, 2025 12:02
sstanculeanu
sstanculeanu previously approved these changes Oct 15, 2025
AdoAdoAdo
AdoAdoAdo previously approved these changes Oct 15, 2025
@codecov

codecov Bot commented Oct 15, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.77778% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.67%. Comparing base (a4dbb07) to head (c312b55).
⚠️ Report is 4 commits behind head on feat/supernova-async-exec.

Files with missing lines Patch % Lines
process/block/shardblock.go 71.42% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat/supernova-async-exec    #7327   +/-   ##
==========================================================
  Coverage                      75.66%   75.67%           
==========================================================
  Files                            860      860           
  Lines                         141687   141718   +31     
==========================================================
+ Hits                          107212   107242   +30     
  Misses                         28530    28530           
- Partials                        5945     5946    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AdoAdoAdo AdoAdoAdo merged commit 53f0a08 into feat/supernova-async-exec Oct 23, 2025
8 of 9 checks passed
@AdoAdoAdo AdoAdoAdo deleted the supernova-tx-pool-commit-integration branch October 23, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants