Bootstrap block v3 by ssd04 · Pull Request #7337 · multiversx/mx-chain-go

ssd04 · 2025-10-13T14:28:02Z

Reasoning behind the pull request

With headerV3 execution results and last execution rootHash will be available LastExecutionResults on the header
On bootstrap, rootHash will have to be taken from LastExecutionResults

Proposed changes

Adapt bootstrap process to fetch rootHash based on execution results if header v3

Testing procedure

With feat branch

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

was the PR targeted to the correct branch?
if this is a larger feature that probably needs more than one PR, is there a feat branch created?
if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

AdoAdoAdo · 2025-10-15T13:12:12Z

+func (e *epochStartBootstrap) getRootHashToSync(
+	header data.HeaderHandler,
+) []byte {
+	rootHashToSync := header.GetRootHash()


this is not correct if there are scheduled transactions, should call e.dataSyncerWithScheduled.GetRootHashToSync
so maybe this function can include also line 1210, and remove it from there?

Also metachain does not have scheduled roothash

right, missed it

AdoAdoAdo · 2025-10-15T13:18:10Z

-			hashDst[string(val.Hash)] = val
+			miniBlockHeader, ok := val.(*block.MiniBlockHeader)
+			if !ok {
+				log.Warn("wrong time assertion for mini block header handler", "err", epochStart.ErrWrongTypeAssertion)


wrong time assertion -> wrong type assertion?

AdoAdoAdo · 2025-10-15T13:33:05Z


-	for _, val := range metaBlock.MiniBlockHeaders {
-		isCrossShardDestMe := (val.ReceiverShardID == destId || val.ReceiverShardID == core.AllShardId) && val.SenderShardID != destId
+	for _, val := range metaBlock.GetMiniBlockHeaderHandlers() {


If the metablock is a metablockV3, the metablock mini-block header handlers of use in shard should be taken from the execution results instead of the ones directly on the metablock (that is the metablock internal proposal).

codecov · 2025-10-16T03:44:12Z

Codecov Report

❌ Patch coverage is 86.42857% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.28%. Comparing base (0767af4) to head (129c05f).
⚠️ Report is 23 commits behind head on feat/supernova-async-exec.

Files with missing lines	Patch %	Lines
epochStart/bootstrap/process.go	86.17%	8 Missing and 5 partials ⚠️
epochStart/bootstrap/shardStorageHandler.go	83.78%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@                      Coverage Diff                      @@
##           feat/supernova-async-exec    #7337      +/-   ##
=============================================================
+ Coverage                      77.27%   77.28%   +0.01%     
=============================================================
  Files                            867      867              
  Lines                         116598   116704     +106     
=============================================================
+ Hits                           90099    90193      +94     
- Misses                         20553    20559       +6     
- Partials                        5946     5952       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sstanculeanu · 2025-10-16T10:47:45Z

+	if lastExecutedNonce >= baseHeaderNonce {
+		return nil
+	}


is this possible?

it should'nt happen, but i've added it as an extra check

sstanculeanu · 2025-10-16T10:56:37Z

+	hashesToRequest := make([][]byte, 0, len(meta.GetEpochStartHandler().GetLastFinalizedHeaderHandlers())+1)
+	shardIds := make([]uint32, 0, len(meta.GetEpochStartHandler().GetLastFinalizedHeaderHandlers())+1)


Suggested change

hashesToRequest := make([][]byte, 0, len(meta.GetEpochStartHandler().GetLastFinalizedHeaderHandlers())+1)

shardIds := make([]uint32, 0, len(meta.GetEpochStartHandler().GetLastFinalizedHeaderHandlers())+1)

hashesToRequest := make([][]byte, 0)

shardIds := make([]uint32, 0)

sstanculeanu · 2025-10-16T10:59:51Z

+	if meta.GetEpoch() == e.startEpoch+1 {
+		syncedHeaders[string(meta.GetEpochStartHandler().GetEconomicsHandler().GetPrevEpochStartHash())] = &block.MetaBlock{}
+	}


can you add a comment here? not clear for me why it is needed

added comment

sstanculeanu · 2025-10-16T11:01:13Z

+
+		epochStartProvider, _ := NewEpochStartBootstrap(args)
+
+		expErr := errors.New("expected error")


extract a global var and reuse it?

sstanculeanu · 2025-10-31T15:09:57Z

+	}
+
+	if headerShard == MetachainShardId {
+		metaExecResult, ok := baseExecResult.(data.MetaExecutionResultHandler)


this should be fixed here: #7364 (comment)

ssd04 added 3 commits October 6, 2025 18:30

change to use rootHash based on execution result

f695835

Merge branch 'sync-block-v3' into bootstrap-block-v3

dae8cdb

use MetaHeaderHandler instead of explicit MetaBlock v1

859dc45

ssd04 self-assigned this Oct 13, 2025

Merge branch 'sync-block-v3' into bootstrap-block-v3

87d6a20

Base automatically changed from sync-block-v3 to feat/supernova-async-exec October 15, 2025 12:01

Merge branch 'feat/supernova-async-exec' into bootstrap-block-v3

8c7ab71

ssd04 marked this pull request as ready for review October 15, 2025 12:01

sstanculeanu previously approved these changes Oct 15, 2025

View reviewed changes

AdoAdoAdo reviewed Oct 15, 2025

View reviewed changes

bootstrap: request intermediate blocks if needed

cf77fbb

ssd04 dismissed sstanculeanu’s stale review via cf77fbb October 15, 2025 14:43

ssd04 added 3 commits October 16, 2025 12:00

added more unit tests

4c85b93

get proper mini blocks on meta header

3918881

fix comment and warn messages

244f328

sstanculeanu reviewed Oct 16, 2025

View reviewed changes

ssd04 added 2 commits October 16, 2025 14:45

fixes after review

1ca89e8

Merge branch 'feat/supernova-async-exec' into bootstrap-block-v3

b5b782e

sstanculeanu previously approved these changes Oct 17, 2025

View reviewed changes

sstanculeanu mentioned this pull request Oct 24, 2025

Update history repository #7365

Merged

sstanculeanu and others added 3 commits October 27, 2025 17:08

Merge branch 'feat/supernova-async-exec' into bootstrap-block-v3

788ed95

Merge branch 'feat/supernova-async-exec' into bootstrap-block-v3

f188470

fixes after merge conflicts

8c40d79

ssd04 dismissed sstanculeanu’s stale review via 8c40d79 October 29, 2025 14:57

AdoAdoAdo reviewed Oct 29, 2025

View reviewed changes

Comment thread epochStart/bootstrap/process.go

Comment thread epochStart/bootstrap/process.go Outdated

Comment thread epochStart/bootstrap/process.go Outdated

Comment thread epochStart/bootstrap/shardStorageHandler.go Outdated

Comment thread epochStart/bootstrap/shardStorageHandler.go Outdated

ssd04 added 2 commits October 30, 2025 14:57

fixes after review

84e828e

Merge branch 'feat/supernova-async-exec' into bootstrap-block-v3

a429730

sstanculeanu previously approved these changes Oct 30, 2025

View reviewed changes

Merge branch 'feat/supernova-async-exec' into bootstrap-block-v3

0e4a423

AdoAdoAdo and others added 2 commits October 31, 2025 15:03

Merge branch 'feat/supernova-async-exec' into bootstrap-block-v3

299340a

get rootHash from epoch start execution result

7a84de0

ssd04 dismissed sstanculeanu’s stale review via 7a84de0 October 31, 2025 15:03

sstanculeanu reviewed Oct 31, 2025

View reviewed changes

sstanculeanu mentioned this pull request Oct 31, 2025

updated pendingMiniBlocks for meta header v3 #7364

Merged

AdoAdoAdo previously approved these changes Oct 31, 2025

View reviewed changes

fixes after review

c2755aa

ssd04 dismissed AdoAdoAdo’s stale review via c2755aa October 31, 2025 15:26

AdoAdoAdo previously approved these changes Oct 31, 2025

View reviewed changes

sstanculeanu previously approved these changes Oct 31, 2025

View reviewed changes

fix proce block test

129c05f

ssd04 dismissed stale reviews from sstanculeanu and AdoAdoAdo via 129c05f October 31, 2025 16:57

sstanculeanu approved these changes Oct 31, 2025

View reviewed changes

AdoAdoAdo approved these changes Nov 1, 2025

View reviewed changes

AdoAdoAdo merged commit e091d18 into feat/supernova-async-exec Nov 1, 2025
11 checks passed

AdoAdoAdo deleted the bootstrap-block-v3 branch November 1, 2025 11:21

		hashesToRequest := make([][]byte, 0, len(meta.GetEpochStartHandler().GetLastFinalizedHeaderHandlers())+1)
		shardIds := make([]uint32, 0, len(meta.GetEpochStartHandler().GetLastFinalizedHeaderHandlers())+1)


		epochStartProvider, _ := NewEpochStartBootstrap(args)

		expErr := errors.New("expected error")

Uh oh!

Conversation

ssd04 commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ssd04 commented Oct 13, 2025 •

edited

Loading

codecov Bot commented Oct 16, 2025 •

edited

Loading