Skip to content

cleanup pools based on last exec results header#7349

Merged
sstanculeanu merged 6 commits into
feat/supernova-async-execfrom
cleanup-pools-header-v3
Oct 28, 2025
Merged

cleanup pools based on last exec results header#7349
sstanculeanu merged 6 commits into
feat/supernova-async-execfrom
cleanup-pools-header-v3

Conversation

@ssd04

@ssd04 ssd04 commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

Reasoning behind the pull request

  • The cleanup done on the data pools upon block commit needs to be adapted for Supernova

  • Before Supernova, the block commit would also cleanup all block, mini-blocks, transactions information from the TxPool related to the committed block (or for the previous committed block) from the corresponding pools

  • With Supernova, a committed block will still be needed to be accessed in the immediate future, when for example the committed block is processed

  • So the cleanup for a header associated data needs to only remove the data from pools, once the header execution results appear on the committed block

  • Cleanup for transactions and mini blocks has already been covered for removeTxsFromPools in another PR

Proposed changes

  • Adapt cleanupPool to get final nonce based on execution results for header V3

Testing procedure

  • With feat branch

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@ssd04 ssd04 self-assigned this Oct 15, 2025
@ssd04 ssd04 marked this pull request as ready for review October 16, 2025 12:31
@codecov

codecov Bot commented Oct 16, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 56.66667% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.67%. Comparing base (c7d4f46) to head (1eb8fe2).

Files with missing lines Patch % Lines
common/common.go 0.00% 11 Missing ⚠️
process/block/baseProcess.go 89.47% 2 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat/supernova-async-exec    #7349   +/-   ##
==========================================================
  Coverage                      75.67%   75.67%           
==========================================================
  Files                            860      860           
  Lines                         141691   141716   +25     
==========================================================
+ Hits                          107225   107245   +20     
- Misses                         28524    28529    +5     
  Partials                        5942     5942           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sstanculeanu sstanculeanu merged commit dffd331 into feat/supernova-async-exec Oct 28, 2025
8 of 9 checks passed
@sstanculeanu sstanculeanu deleted the cleanup-pools-header-v3 branch October 28, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants