cleanup pools based on last exec results header#7349
Merged
Conversation
sstanculeanu
approved these changes
Oct 16, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/supernova-async-exec #7349 +/- ##
==========================================================
Coverage 75.67% 75.67%
==========================================================
Files 860 860
Lines 141691 141716 +25
==========================================================
+ Hits 107225 107245 +20
- Misses 28524 28529 +5
Partials 5942 5942 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AdoAdoAdo
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
The cleanup done on the data pools upon block commit needs to be adapted for Supernova
Before Supernova, the block commit would also cleanup all block, mini-blocks, transactions information from the TxPool related to the committed block (or for the previous committed block) from the corresponding pools
With Supernova, a committed block will still be needed to be accessed in the immediate future, when for example the committed block is processed
So the cleanup for a header associated data needs to only remove the data from pools, once the header execution results appear on the committed block
Cleanup for transactions and mini blocks has already been covered for
removeTxsFromPoolsin another PRProposed changes
cleanupPoolto get final nonce based on execution results for header V3Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?