MX-17245 · Improve shard processor coverage#7350
Merged
sstanculeanu merged 19 commits intoOct 27, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/supernova-async-exec #7350 +/- ##
=============================================================
+ Coverage 75.68% 75.69% +0.01%
=============================================================
Files 860 860
Lines 141702 141698 -4
=============================================================
+ Hits 107248 107264 +16
+ Misses 28514 28500 -14
+ Partials 5940 5934 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| return sp.collectExecutionResults(headerHash, header, body) | ||
| } | ||
|
|
||
| func (sp *shardProcessor) AddExecutionResultsOnHeader(shardHeader data.HeaderHandler) error { |
Collaborator
There was a problem hiding this comment.
missing comments on exported methods
| for name, component := range subcomponents { | ||
| if err := setField(sp, name, component); err != nil { | ||
| if err2 := setField(sp.baseProcessor, name, component); err2 != nil { | ||
| return nil, err |
Collaborator
There was a problem hiding this comment.
is it intended here err or should it be err2? (perhaps rename err2 to errSetBaseProcessor)
Author
There was a problem hiding this comment.
removed it altogether, it was not really necessary
Comment on lines
+479
to
+480
| return nil, fmt.Errorf("%w : getAllMiniBlockDstMeFromShards shardInfo.HeaderHash = %s", | ||
| process.ErrMissingHeader, hex.EncodeToString(shardInfo.HeaderHash)) |
Collaborator
There was a problem hiding this comment.
not sure we should add the name of the func inside the error.. maybe this could become somthing like
Suggested change
| return nil, fmt.Errorf("%w : getAllMiniBlockDstMeFromShards shardInfo.HeaderHash = %s", | |
| process.ErrMissingHeader, hex.EncodeToString(shardInfo.HeaderHash)) | |
| return nil, fmt.Errorf("%w for shard info with hash = %s", | |
| process.ErrMissingHeader, hex.EncodeToString(shardInfo.HeaderHash)) |
similar for all
Comment on lines
+1855
to
+1856
| return nil, fmt.Errorf("%w : getAllMiniBlockDstMeFromMeta metaBlockHash = %s", | ||
| process.ErrMissingHeader, hex.EncodeToString(metaBlockHash)) |
Collaborator
There was a problem hiding this comment.
same here:
Suggested change
| return nil, fmt.Errorf("%w : getAllMiniBlockDstMeFromMeta metaBlockHash = %s", | |
| process.ErrMissingHeader, hex.EncodeToString(metaBlockHash)) | |
| return nil, fmt.Errorf("%w for metaBlockHash %s", | |
| process.ErrMissingHeader, hex.EncodeToString(metaBlockHash)) |
| // but add them into pendingMiniBlocksAndHashes | ||
| if lastMBIndex != len(mbsSlice) { | ||
| pendingMiniBlocksAndHashes = miniBlocksAndHashes[lastMBIndex:] | ||
| if lastMBIndex+1 < len(mbsSlice) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if lastMBIndex+1 < len(mbsSlice) { | |
| if lastMBIndex < len(mbsSlice) - 1 { |
| }, | ||
| } | ||
| } | ||
| //body := &block.Body{} |
Comment on lines
+4852
to
+4858
| type gracePeriodErrStub struct{} | ||
|
|
||
| func (gracePeriodErrStub) GetGracePeriodForEpoch(_ uint32) (uint32, error) { | ||
| return 0, errors.New("epochChangeGracePeriodHandler forced error") | ||
| } | ||
|
|
||
| func (gracePeriodErrStub) IsInterfaceNil() bool { return false } |
Collaborator
There was a problem hiding this comment.
extract it into a new file as a regular mock + comments on exported
| func TestShardProcessor_CheckEpochCorrectnessShouldErrorWhenIsHeaderOfInvalidEpoch(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| // isHeaderOfInvalidEpoch := header.GetEpoch() > sp.epochStartTrigger.MetaEpoch() |
| }, | ||
| } | ||
|
|
||
| //make epochChangeConfirmed true (sp.epochStartTrigger.EpochStartRound() <= sp.epochStartTrigger.EpochFinalityAttestingRound()) |
| func TestShardProcessor_CheckEpochCorrectnessShouldErrorWhenIsNotEpochStartButShouldBe(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| //isNotEpochStartButShouldBe := header.GetEpoch() != currentBlockHeader.GetEpoch() && !header.IsStartOfEpochBlock() |
AdoAdoAdo
approved these changes
Oct 27, 2025
sstanculeanu
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Increase cover of shardProcessor and txCoordinator
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?