Chain handler last execution info by ssd04 · Pull Request #7356 · multiversx/mx-chain-go

ssd04 · 2025-10-20T13:43:43Z

Reasoning behind the pull request

With the new execution model, we need to differentiate in chain handler current notarized block (from consensus flow) and last executed block (from async execution flow)
For this, a new set of fields have been added to chain handler in order to be able to fetch last executed block info

Proposed changes

Added last executed (on local executor) block info in chain handler
Adapt chain handler integrations to use rootHash based on last executed results

Testing procedure

With feature branch

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

was the PR targeted to the correct branch?
if this is a larger feature that probably needs more than one PR, is there a feat branch created?
if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

codecov · 2025-10-20T13:52:11Z

Codecov Report

❌ Patch coverage is 79.59184% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.31%. Comparing base (857919f) to head (e053c0d).
⚠️ Report is 21 commits behind head on feat/supernova-async-exec.

Files with missing lines	Patch %	Lines
process/block/shardblockProposal.go	45.45%	3 Missing and 3 partials ⚠️
process/smartContract/scQueryService.go	33.33%	5 Missing and 1 partial ⚠️
...external/transactionAPI/apiTransactionProcessor.go	82.60%	2 Missing and 2 partials ⚠️
process/block/shardblock.go	0.00%	1 Missing and 1 partial ⚠️
state/blockInfoProviders/currentBlockInfo.go	71.42%	2 Missing ⚠️

Additional details and impacted files

@@                    Coverage Diff                     @@
##           feat/supernova-async-exec    #7356   +/-   ##
==========================================================
  Coverage                      77.31%   77.31%           
==========================================================
  Files                            867      867           
  Lines                         116789   116874   +85     
==========================================================
+ Hits                           90292    90364   +72     
- Misses                         20548    20555    +7     
- Partials                        5949     5955    +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…ution-info

raduchis · 2025-10-28T10:20:22Z

 }

+func (nf *nodeFacade) getCurrentRootHash() []byte {
+	currentHeader := nf.blockchain.GetCurrentBlockHeader()


could the currentHeader be nil?

added nil check

raduchis · 2025-10-28T11:43:36Z

+		return bh.blockChain.GetCurrentBlockRootHash()
+	}
+
+	_, _, lastExecutedRootHash := bh.blockChain.GetLastExecutedBlockInfo()


If the currentHeader is nil this might return something slightly different than the apiTransactionsProcessor.go line 492 - getCurrentRootHash and nodeFacade.go line 638 - getCurrentRootHash.
Is there any way to "unify" the responses?

…ution-info

raduchis · 2025-10-29T08:10:03Z

 }

+func (nf *nodeFacade) getCurrentRootHash() []byte {
+	currentHeader := nf.blockchain.GetCurrentBlockHeader()


is this method backwards compatible? Previously with or without nil currentHeader the nf.blockchain.GetCurrentBlockRootHash() was returned. Right now if the currentHeader is nil, it will return the nf.blockchain.GetLastExecutedBlockInfo().
It might not matter because it is on the nodeFacade...

maybe do this instead to keep it backwards compatible:

if currentHeader != nil && currentHeader.IsHeaderV3() { _, _, lastExecutedRootHash := nf.blockchain.GetLastExecutedBlockInfo() return lastExecutedRootHash } return nf.blockchain.GetCurrentBlockRootHash()

AdoAdoAdo · 2025-10-29T12:51:58Z

 	headerHash []byte,
 	scheduledHeaderRootHash []byte,
 ) {
+	if header.IsHeaderV3() {


why is this different than Andromeda?

after supernova we set last execution info from headersExecutor

AdoAdoAdo · 2025-10-29T13:03:05Z

 }

 func (he *headersExecutor) process(pair queue.HeaderBodyPair) error {
 	executionResult, err := he.blockProcessor.ProcessBlockProposal(pair.Header, pair.Body)


We could use a check inside ProcessBlockProposal, that we start the execution from the correct roothash.

can you add this on shardblock with a todo to add it also for the metablock?

added root hash check

AdoAdoAdo · 2025-10-29T14:36:01Z

+		return nil, ErrNilBlockHeader
+	}
+
+	if blockHeader.IsHeaderV3() {


when committing the first v3 header, do we create a lastExecutedBlockInfo from the previous V2 block?
otherwise we might have a gap here.

AdoAdoAdo · 2025-10-29T14:39:41Z

 	finalBlockHash     []byte
 	finalBlockRootHash []byte
+
+	lastNotarizedBlockNonce    uint64


why is it called lastNotarized?
should it be lastExecuted ?

right, renamed

AdoAdoAdo · 2025-10-29T14:44:30Z

 }

+func (nf *nodeFacade) getCurrentRootHash() []byte {
+	currentHeader := nf.blockchain.GetCurrentBlockHeader()


maybe do this instead to keep it backwards compatible:

if currentHeader != nil && currentHeader.IsHeaderV3() { _, _, lastExecutedRootHash := nf.blockchain.GetLastExecutedBlockInfo() return lastExecutedRootHash } return nf.blockchain.GetCurrentBlockRootHash()

…ution-info

Copilot

Pull Request Overview

This PR adds support for tracking last executed block information separately from current block info, primarily to support HeaderV3 where block execution happens asynchronously. The changes introduce GetLastExecutedBlockInfo and SetLastExecutedBlockInfo methods across chain handlers and update various components to use last executed block info for state root hash retrieval when dealing with HeaderV3.

Key changes:

New methods GetLastExecutedBlockInfo() and SetLastExecutedBlockInfo() added to chain handler interfaces and implementations
State root hash retrieval logic updated to use last executed block info for HeaderV3
Headers executor now sets both final block info and last executed block info after processing
New validation check added before block execution to verify root hash consistency

Reviewed Changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
testscommon/chainHandlerStub.go	Added stub methods for last executed block info
testscommon/chainHandlerMock.go	Added mock implementation with fields for last executed block tracking
dataRetriever/blockchain/baseBlockchain.go	Core implementation of last executed block info getters/setters
dataRetriever/blockchain/blockchain.go	Initialized last executed block info in shard blockchain
dataRetriever/blockchain/metachain.go	Initialized last executed block info in meta blockchain
process/asyncExecution/headersExecutor.go	Sets both final and last executed block info after processing
state/blockInfoProviders/currentBlockInfo.go	Uses last executed info for HeaderV3
process/smartContract/hooks/blockChainHook.go	Retrieves root hash from last executed info for HeaderV3
process/smartContract/scQueryService.go	Query service uses last executed header/root for HeaderV3
node/external/transactionAPI/apiTransactionProcessor.go	API processor retrieves root hash from last executed info for HeaderV3
facade/nodeFacade.go	Facade retrieves root hash from last executed info for HeaderV3
process/block/shardblock.go	Skips setting final block info for HeaderV3 (handled in async executor)
process/block/shardblockProposal.go	Adds root hash validation check before execution
go.mod	Updated mx-chain-core-go dependency version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-01T12:12:11Z

+	lastCommitedRootHash, err := sp.accountsDB[state.UserAccountsState].RootHash()
+	if err != nil {
+		return err
+	}
+
+	currentRootHash := sp.blockChain.GetCurrentBlockRootHash()
+	if !bytes.Equal(lastCommitedRootHash, currentRootHash) {


Corrected spelling of 'lastCommitedRootHash' to 'lastCommittedRootHash'.

Suggested change

lastCommitedRootHash, err := sp.accountsDB[state.UserAccountsState].RootHash()

if err != nil {

return err

}

currentRootHash := sp.blockChain.GetCurrentBlockRootHash()

if !bytes.Equal(lastCommitedRootHash, currentRootHash) {

lastCommittedRootHash, err := sp.accountsDB[state.UserAccountsState].RootHash()

if err != nil {

return err

}

currentRootHash := sp.blockChain.GetCurrentBlockRootHash()

if !bytes.Equal(lastCommittedRootHash, currentRootHash) {

Copilot · 2025-11-01T12:12:12Z

+		}
+		arg.Node = &mock.NodeStub{
+			GetProofCalled: func(rootHash string, _ string) (*common.GetProofResponse, error) {
+				require.Equal(t, rootHash, rootHash)


The assertion compares rootHash with itself, which always passes. This should likely compare the rootHash parameter against the expected value from line 1148.

Suggested change

require.Equal(t, rootHash, rootHash)

require.Equal(t, string(rootHash1), rootHash)

ssd04 added 5 commits October 20, 2025 12:33

added last execution info methods in chain handler

8244922

header v3 check

636b56a

fix mocks

3d01e4a

adapt set final info

d1490e4

added unit tests

0f657a3

ssd04 self-assigned this Oct 20, 2025

ssd04 added 4 commits October 21, 2025 11:40

add block to chain handler in headers executor

5387ab9

adapt to use root hash from last executed

14cd242

fix process tests

fefb924

Merge branch 'feat/supernova-async-exec' into chain-handler-last-exec…

a6c9cd9

…ution-info

ssd04 marked this pull request as ready for review October 21, 2025 10:40

ssd04 added 2 commits October 21, 2025 13:43

remove commented code

db1e235

remove set last notarized on process

d1ae451

sstanculeanu previously approved these changes Oct 21, 2025

View reviewed changes

raduchis self-requested a review October 28, 2025 10:03

raduchis reviewed Oct 28, 2025

View reviewed changes

ssd04 added 2 commits October 28, 2025 15:19

Merge branch 'feat/supernova-async-exec' into chain-handler-last-exec…

16c8afe

…ution-info

fixes after merge conflicts

e2e5137

ssd04 dismissed sstanculeanu’s stale review via e2e5137 October 28, 2025 13:28

added nil check

1db5c56

raduchis reviewed Oct 29, 2025

View reviewed changes

AdoAdoAdo reviewed Oct 29, 2025

View reviewed changes

ssd04 added 3 commits October 30, 2025 16:51

Merge branch 'feat/supernova-async-exec' into chain-handler-last-exec…

e52c7da

…ution-info

fixes after review

481e72f

fixes after review

5443792

AdoAdoAdo previously approved these changes Nov 1, 2025

View reviewed changes

Merge branch 'feat/supernova-async-exec' into chain-handler-last-exec…

db371eb

…ution-info

AdoAdoAdo dismissed their stale review via db371eb November 1, 2025 12:04

AdoAdoAdo previously approved these changes Nov 1, 2025

View reviewed changes

AdoAdoAdo requested a review from Copilot November 1, 2025 12:06

Copilot AI reviewed Nov 1, 2025

View reviewed changes

fixes after review

e053c0d

ssd04 dismissed AdoAdoAdo’s stale review via e053c0d November 3, 2025 07:47

sstanculeanu approved these changes Nov 3, 2025

View reviewed changes

AdoAdoAdo approved these changes Nov 3, 2025

View reviewed changes

AdoAdoAdo merged commit e96692e into feat/supernova-async-exec Nov 3, 2025
11 checks passed

AdoAdoAdo deleted the chain-handler-last-execution-info branch November 3, 2025 08:00

	require.Equal(t, rootHash, rootHash)
	require.Equal(t, string(rootHash1), rootHash)

Uh oh!

Conversation

ssd04 commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Uh oh!

codecov Bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ssd04 commented Oct 20, 2025 •

edited

Loading

codecov Bot commented Oct 20, 2025 •

edited

Loading