Revert incoming miniblocks#7357
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/supernova-async-exec #7357 +/- ##
=============================================================
+ Coverage 75.69% 77.27% +1.57%
=============================================================
Files 860 867 +7
Lines 141698 116598 -25100
=============================================================
- Hits 107264 90105 -17159
+ Misses 28500 20547 -7953
- Partials 5934 5946 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ssd04
previously approved these changes
Oct 21, 2025
AdoAdoAdo
reviewed
Oct 30, 2025
| gc.RevertIncomingMiniBlocks([][]byte{firstPendingHash}) | ||
|
|
||
| // check that pending mini blocks were updated | ||
| updatedPendingMiniBlocks := gc.GetPendingMiniBlocks() |
Contributor
There was a problem hiding this comment.
can you validate also the updated totalGas in the revert tests as not all of them are currently doing it
ssd04
approved these changes
Oct 30, 2025
AdoAdoAdo
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?