Skip to content

Revert incoming miniblocks#7357

Merged
AdoAdoAdo merged 4 commits into
feat/supernova-async-execfrom
revert-incoming-miniblocks
Oct 31, 2025
Merged

Revert incoming miniblocks#7357
AdoAdoAdo merged 4 commits into
feat/supernova-async-execfrom
revert-incoming-miniblocks

Conversation

@sstanculeanu

Copy link
Copy Markdown
Collaborator

Reasoning behind the pull request

  • we need a way to revert some miniblocks from gasConsumption component

Proposed changes

  • implemented RevertIncomingMiniBlocks which should clean all the provided miniblocks from the local state

Testing procedure

  • with feat branch

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu self-assigned this Oct 20, 2025
@sstanculeanu sstanculeanu added the ignore-for-release-notes Do not include item in release notes label Oct 20, 2025
@codecov

codecov Bot commented Oct 20, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.27%. Comparing base (2e37fa8) to head (4853ab7).
⚠️ Report is 490 commits behind head on feat/supernova-async-exec.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           feat/supernova-async-exec    #7357      +/-   ##
=============================================================
+ Coverage                      75.69%   77.27%   +1.57%     
=============================================================
  Files                            860      867       +7     
  Lines                         141698   116598   -25100     
=============================================================
- Hits                          107264    90105   -17159     
+ Misses                         28500    20547    -7953     
- Partials                        5934     5946      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ssd04
ssd04 previously approved these changes Oct 21, 2025
gc.RevertIncomingMiniBlocks([][]byte{firstPendingHash})

// check that pending mini blocks were updated
updatedPendingMiniBlocks := gc.GetPendingMiniBlocks()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you validate also the updated totalGas in the revert tests as not all of them are currently doing it

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed

@AdoAdoAdo AdoAdoAdo merged commit ec1f5bc into feat/supernova-async-exec Oct 31, 2025
11 checks passed
@AdoAdoAdo AdoAdoAdo deleted the revert-incoming-miniblocks branch October 31, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes Do not include item in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants