updated pendingMiniBlocks for meta header v3#7364
Conversation
| return crossShardMiniBlocks, nil | ||
| } | ||
|
|
||
| func getMiniBlocksFromHeader(header data.MetaHeaderHandler) ([]data.MiniBlockHeaderHandler, error) { |
There was a problem hiding this comment.
maybe rename this to getMiniBlocksFromHeaderReadyForCrossShardExecution() ?
| } | ||
|
|
||
| func (p *pendingMiniBlocks) getAllCrossShardMiniBlocksHashes(metaBlock data.MetaHeaderHandler) map[string]uint32 { | ||
| func (p *pendingMiniBlocks) getAllCrossShardMiniBlocksHashes(metaBlock data.MetaHeaderHandler) (map[string]uint32, error) { |
There was a problem hiding this comment.
maybe rename to getMiniBlocksHashesReadyForCrossShardExecution
…ersx/mx-chain-go into pendingMiniBlocks-for-hv3 # Conflicts: # common/common.go
| } | ||
|
|
||
| if headerShard == MetachainShardId { | ||
| metaExecResult, ok := baseExecResult.(data.MetaExecutionResultHandler) |
There was a problem hiding this comment.
if there was an interface with only the GetMiniBlockHeadersHandlers() method, the headerShard could be discarded and the current method would be simplified. Could also remain like this.
type ExecutionResultHandler interface {
GetMiniBlockHeadersHandlers()
}
There was a problem hiding this comment.
moved on the PR implementing this method: #7337 (comment)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/supernova-async-exec #7364 +/- ##
=============================================================
- Coverage 77.31% 77.31% -0.01%
=============================================================
Files 867 867
Lines 116874 116890 +16
=============================================================
+ Hits 90364 90369 +5
- Misses 20555 20564 +9
- Partials 5955 5957 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?