Unit tests - Update history repository#7371
Merged
miiu96 merged 8 commits intoOct 29, 2025
Merged
Conversation
…db-lookup-ext-supernova
| return nil, ErrMockMarshalizer | ||
| } | ||
|
|
||
| if mm.MarshalCalled != nil { |
Collaborator
There was a problem hiding this comment.
we already have MarshalizerStub in the same package that does that, so maybe reuse that implementation
| t.Run("should return error", func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| expectedError := errors.New("expected error") |
Collaborator
There was a problem hiding this comment.
extract it globally and reuse it?
sstanculeanu
previously approved these changes
Oct 27, 2025
miiu96
previously approved these changes
Oct 28, 2025
Base automatically changed from
update-db-lookup-ext-supernova
to
feat/supernova-async-exec
October 29, 2025 12:37
miiu96
dismissed stale reviews from sstanculeanu and themself
The base branch was changed.
…okup-ext-supernova
miiu96
previously approved these changes
Oct 29, 2025
sstanculeanu
previously approved these changes
Oct 29, 2025
danielradu10
dismissed stale reviews from sstanculeanu and miiu96
via
7d2aff1
sstanculeanu
approved these changes
Oct 29, 2025
miiu96
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?