Feat/sub second round 2#7374
Merged
Merged
Conversation
…-sub-second-round-2 Merge rc supernova into feat sub second round 2
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements sub-second round timing support (Supernova feature) by introducing a round-based enable handler and a configurable unbond period that varies based on whether the Supernova round flag is active.
Key Changes
- Added
EnableRoundsHandlerto enable/disable features based on round numbers instead of epochs - Introduced
UnBondPeriodSupernovaconfiguration to allow different unbond periods after the Supernova activation - Removed
RoundDurationMillisecondsparameter fromRatingsData, now sourced from chain parameters
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| vm/systemSmartContracts/staking.go | Added enableRoundsHandler and unBondPeriodSupernova fields with logic to dynamically select unbond period based on round |
| vm/systemSmartContracts/staking_test.go | Added tests for nil handlers and Supernova unbond period behavior |
| vm/factory/systemSCFactory.go | Integrated EnableRoundsHandler into system smart contract factory |
| vm/errors.go | Added ErrNilEnableRoundsHandler error |
| process/rating/ratingsData.go | Removed roundDurationInMilliseconds field, now using RoundDuration from chain parameters |
| config/systemSmartContractsConfig.go | Added UnBondPeriodSupernova configuration field |
| cmd/node/config/systemSmartContractsConfig.toml | Added UnBondPeriodSupernova = 2500 configuration value |
| Multiple test files | Added EnableRoundsHandler stub to test setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Run Tests: |
|
❌ Integration Tests completed with failures or errors. 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
❌ Integration Tests completed with failures or errors. 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
New chain simulator parameters
sstanculeanu
previously approved these changes
Nov 7, 2025
AdoAdoAdo
previously approved these changes
Nov 7, 2025
|
❌ Integration Tests completed with failures or errors. 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## rc/supernova #7374 +/- ##
================================================
+ Coverage 75.30% 76.80% +1.49%
================================================
Files 842 846 +4
Lines 138067 113121 -24946
================================================
- Hits 103969 86880 -17089
+ Misses 28270 20396 -7874
- Partials 5828 5845 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miiu96
previously approved these changes
Nov 7, 2025
…duration Fix round duration milliseconds in chain simulator
AdoAdoAdo
dismissed stale reviews from miiu96, sstanculeanu, and themself
via
63cf85d
AdoAdoAdo
previously approved these changes
Nov 7, 2025
sstanculeanu
approved these changes
Nov 7, 2025
sstanculeanu
previously approved these changes
Nov 7, 2025
schimih
previously approved these changes
Nov 7, 2025
|
❌ Integration Tests completed with failures or errors. 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
sstanculeanu
dismissed stale reviews from schimih, AdoAdoAdo, and themself
via
ae4722a
|
❌ Integration Tests completed with failures or errors. 📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
AdoAdoAdo
approved these changes
Nov 8, 2025
sstanculeanu
approved these changes
Nov 8, 2025
miiu96
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?