Revert supply changes based on execution results#7385
Merged
miiu96 merged 8 commits intoNov 4, 2025
Merged
Conversation
…d-on-execution-results
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/supernova-async-exec #7385 +/- ##
==========================================================
Coverage 77.31% 77.31%
==========================================================
Files 867 867
Lines 116890 116904 +14
==========================================================
+ Hits 90369 90383 +14
+ Misses 20564 20562 -2
- Partials 5957 5959 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…d-on-execution-results # Conflicts: # common/common.go # process/asyncExecution/executionTrack/error.go # process/interface.go # testscommon/executionTrack/executionResultsTrackerStub.go
sstanculeanu
previously approved these changes
Nov 3, 2025
Comment on lines
+1115
to
+1120
| err := bp.executionResultsTracker.CleanConfirmedExecutionResults(header) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil |
Collaborator
There was a problem hiding this comment.
Suggested change
| err := bp.executionResultsTracker.CleanConfirmedExecutionResults(header) | |
| if err != nil { | |
| return err | |
| } | |
| return nil | |
| return bp.executionResultsTracker.CleanConfirmedExecutionResults(header) |
ssd04
reviewed
Nov 4, 2025
| func TestProcessLogs_RevertChangesHeaderV3(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| t.Run("cannot get mb headers should err", func(t *testing.T) { |
Contributor
There was a problem hiding this comment.
parallel run for inner tests?
Comment on lines
+21
to
+22
| // ErrExecutionResultMissmatch signals an execution result missmatch | ||
| ErrExecutionResultMissmatch = errors.New("execution result mismatch") |
Contributor
There was a problem hiding this comment.
Suggested change
| // ErrExecutionResultMissmatch signals an execution result missmatch | |
| ErrExecutionResultMissmatch = errors.New("execution result mismatch") | |
| // ErrExecutionResultMismatch signals an execution result mismatch | |
| ErrExecutionResultMismatch = errors.New("execution result mismatch") |
ssd04
approved these changes
Nov 4, 2025
sstanculeanu
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?