drop proofs and headers received too late in the next round by sstanculeanu · Pull Request #7804 · multiversx/mx-chain-go

sstanculeanu · 2026-03-27T10:43:42Z

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

was the PR targeted to the correct branch?
if this is a larger feature that probably needs more than one PR, is there a feat branch created?
if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

codecov · 2026-03-27T10:49:51Z

Codecov Report

❌ Patch coverage is 95.16129% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.56%. Comparing base (7caded5) to head (03df0bc).

Files with missing lines	Patch %	Lines
...de/chainSimulator/components/manualRoundHandler.go	0.00%	2 Missing ⚠️
...rceptors/factory/interceptedTrieNodeDataFactory.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                    Coverage Diff                     @@
##           feat/supernova-async-exec    #7804   +/-   ##
==========================================================
  Coverage                      77.56%   77.56%           
==========================================================
  Files                            882      882           
  Lines                         123719   123752   +33     
==========================================================
+ Hits                           95958    95987   +29     
- Misses                         21402    21407    +5     
+ Partials                        6359     6358    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ssd04 · 2026-03-27T14:27:18Z


+	currentRoundStart := bbt.roundHandler.TimeStamp()
+	roundDuration := float64(bbt.roundHandler.TimeDuration())
+	maxTimeToAcceptProof := time.Duration(roundDuration + roundDuration*receivedProofDelay)


Suggested change

maxTimeToAcceptProof := time.Duration(roundDuration + roundDuration*receivedProofDelay)

maxTimeToAcceptProof := time.Duration(currentRoundStart + roundDuration*receivedProofDelay)

it should be based on start round time, right?

no, max time parameter is the total amount of time (900 ms in this case), as RemainingTime is called with currentRoundStart

ssd04 · 2026-03-27T14:28:48Z

+			RemainingTimeCalled: func(startTime time.Time, maxTime time.Duration) time.Duration {
+				currentTime := time.Now()
+				elapsedTime := currentTime.Sub(startTime)
+				remainingTime := maxTime - elapsedTime
+
+				return remainingTime
+			},


can we use real RemainingTime method from round handler?

maybe use real round handler, and call UpdateRound several times to set the desired index (with lower test values)

that should work too, tried to keep it simple

Copilot

Pull request overview

This PR attempts to enforce a time window for accepting “next round” headers/proofs, so that items received too late are dropped, and wires round timing data through the process.RoundHandler interface to support that logic.

Changes:

Extend process.RoundHandler with TimeStamp() and RemainingTime(...) to support time-window validation.
Add a time-window check in baseBlockTrack.checkAgainstRoundHandler.
Update mocks and add a unit test intended to cover the “too-late” rejection behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
process/track/baseBlockTrack.go	Adds time-window rejection logic for headers/proofs based on round timing.
process/track/baseBlockTrack_test.go	Updates round handler setup in tests and adds a new “invalid window” test.
process/mock/rounderMock.go	Extends the process mock to support `RemainingTime` injection via callback.
process/interface.go	Extends `process.RoundHandler` with timestamp and remaining-time methods.
integrationTests/testProcessorNode.go	Updates integration-test round handler mock initialization for new interface expectations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-27T14:55:27Z

+	// wait until after half of the next round passed
+	timeToSleep := roundDuration + time.Duration(float64(roundDuration)*0.6)
+	time.Sleep(timeToSleep)


The test relies on real time (time.Sleep) to cross the acceptance window, which makes the suite slower and can be flaky under CI scheduling variance. Prefer a deterministic approach (e.g., set RoundTimeStamp far enough in the past or have RemainingTimeCalled return a controlled negative value) so the test doesn’t depend on wall-clock timing.

should work

Copilot · 2026-03-27T14:55:27Z

+	roundDuration := float64(bbt.roundHandler.TimeDuration())
+	maxTimeToAcceptProof := time.Duration(roundDuration + roundDuration*receivedProofDelay)
+	timeLeftToAcceptProof := bbt.roundHandler.RemainingTime(currentRoundStart, maxTimeToAcceptProof)
+	if timeLeftToAcceptProof <= 0 {
+		return fmt.Errorf("%w header round: %d, current round timestamp: %d, time left to accept proof: %d",
+			process.ErrHigherRoundInBlock,
+			round,
+			currentRoundStart.UnixMilli(),


The new time-window check is effectively inert with the real consensus/round implementation: RemainingTime(TimeStamp(), 1.5*TimeDuration) will stay >0 because TimeStamp() is updated each round and elapsed is always < TimeDuration(). As a result, headers/proofs won’t actually be dropped “when received too late in the next round”. Consider basing the window on the received item’s round (e.g., compute the start timestamp of that round and enforce acceptance only for the first receivedProofDelay fraction of it), or otherwise use a start time that doesn’t reset every round when validating next-round items.

Suggested change

roundDuration := float64(bbt.roundHandler.TimeDuration())

maxTimeToAcceptProof := time.Duration(roundDuration + roundDuration*receivedProofDelay)

timeLeftToAcceptProof := bbt.roundHandler.RemainingTime(currentRoundStart, maxTimeToAcceptProof)

if timeLeftToAcceptProof <= 0 {

return fmt.Errorf("%w header round: %d, current round timestamp: %d, time left to accept proof: %d",

process.ErrHigherRoundInBlock,

round,

currentRoundStart.UnixMilli(),

roundDuration := bbt.roundHandler.TimeDuration()

maxTimeToAcceptProof := time.Duration(float64(roundDuration) * (1 + receivedProofDelay))

roundDiff := int64(round) - int64(bbt.roundHandler.Index())

itemRoundStart := currentRoundStart.Add(time.Duration(roundDiff) * roundDuration)

timeLeftToAcceptProof := bbt.roundHandler.RemainingTime(itemRoundStart, maxTimeToAcceptProof)

if timeLeftToAcceptProof <= 0 {

return fmt.Errorf("%w header round: %d, item round timestamp: %d, time left to accept proof: %d",

process.ErrHigherRoundInBlock,

round,

itemRoundStart.UnixMilli(),

Copilot · 2026-03-27T14:55:28Z

+	roundDuration := float64(bbt.roundHandler.TimeDuration())
+	maxTimeToAcceptProof := time.Duration(roundDuration + roundDuration*receivedProofDelay)


maxTimeToAcceptProof is built via float64(time.Duration) arithmetic. Converting durations to float can introduce precision/rounding issues and is harder to reason about. Prefer pure time.Duration math (e.g., derive the extra window using integer arithmetic or a rational numerator/denominator) so the acceptance window is exact and overflow-safe.

Suggested change

roundDuration := float64(bbt.roundHandler.TimeDuration())

maxTimeToAcceptProof := time.Duration(roundDuration + roundDuration*receivedProofDelay)

roundDuration := bbt.roundHandler.TimeDuration()

extraWindow := time.Duration(float64(roundDuration.Nanoseconds()) * receivedProofDelay)

maxTimeToAcceptProof := roundDuration + extraWindow

should be ok

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…erceptor

AdoAdoAdo · 2026-03-30T14:01:03Z

+	timeLeftToAcceptProof := bbt.roundHandler.RemainingTime(roundTimestamp, maxTimeToAcceptProof)
+	if timeLeftToAcceptProof <= 0 {
+		return fmt.Errorf("%w header round: %d, current round timestamp: %d, time left to accept proof: %d",
+			process.ErrHigherRoundInBlock,


maybe use another error? this one might be misleading.

…erceptor

drop proofs and headers received too late in the next round

f5192bb

sstanculeanu self-assigned this Mar 27, 2026

fix tests

47e280e

ssd04 reviewed Mar 27, 2026

View reviewed changes

AdoAdoAdo requested a review from Copilot March 27, 2026 14:48

Copilot started reviewing on behalf of AdoAdoAdo March 27, 2026 14:49 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

sstanculeanu and others added 4 commits March 30, 2026 13:21

Update process/track/baseBlockTrack.go

ed3e604

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fixes after copilot

d66e7bf

fixed linter

7dc66fd

Merge branch 'feat/supernova-async-exec' into round-boundaries-on-int…

5245d0c

…erceptor

AdoAdoAdo self-requested a review March 30, 2026 13:39

AdoAdoAdo previously approved these changes Mar 30, 2026

View reviewed changes

fix after review

f797214

sstanculeanu dismissed AdoAdoAdo’s stale review via f797214 March 30, 2026 14:05

sstanculeanu and others added 6 commits March 31, 2026 11:36

fix after test: bring broadcast method into interceptor

147e242

Merge branch 'feat/supernova-async-exec' into round-boundaries-on-int…

a354c3d

…erceptor

new method ComputeCurrentRound

1d0b2e2

fix tests

03df0bc

remove header by nonce so all headers will be removed

03507d5

Merge branch 'feat/supernova-async-exec' into round-boundaries-on-int…

956cc86

…erceptor

Base automatically changed from feat/supernova-async-exec to rc/supernova April 6, 2026 07:58

Merge branch 'rc/supernova' into round-boundaries-on-interceptor

9b9ec8a

sstanculeanu changed the base branch from rc/supernova to feat/testnet-fixes April 6, 2026 12:33

	maxTimeToAcceptProof := time.Duration(roundDuration + roundDuration*receivedProofDelay)
	maxTimeToAcceptProof := time.Duration(currentRoundStart + roundDuration*receivedProofDelay)

		roundDuration := float64(bbt.roundHandler.TimeDuration())
		maxTimeToAcceptProof := time.Duration(roundDuration + roundDuration*receivedProofDelay)

-	roundDuration := float64(bbt.roundHandler.TimeDuration())
-	maxTimeToAcceptProof := time.Duration(roundDuration + roundDuration*receivedProofDelay)
+	roundDuration := bbt.roundHandler.TimeDuration()
+	extraWindow := time.Duration(float64(roundDuration.Nanoseconds()) * receivedProofDelay)
+	maxTimeToAcceptProof := roundDuration + extraWindow

Conversation

sstanculeanu commented Mar 27, 2026

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Uh oh!

codecov Bot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Mar 27, 2026 •

edited

Loading