re-trial on transient execution result mismatch#7901
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an automatic recovery path for shard bootstrap syncing when a transient ErrExecutionResultDoesNotMatch occurs, by rewinding local pending execution results and triggering re-execution, with a per-nonce cooldown to prevent repeated rewinds.
Changes:
- Add recovery logic in
baseBootstrap.doJobOnSyncBlockFail()to handle execution-result mismatches by removing pending results from the first diverging nonce (or from last notarized + 1). - Track recovery attempts per nonce with a cooldown window, and clean up attempt-tracking data behind the final block nonce.
- Add a comprehensive shard bootstrap test suite covering mismatch scenarios, fallbacks, cooldown behavior, and failure modes, plus test-only accessors.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| process/sync/baseSync.go | Adds mismatch-recovery logic with per-nonce cooldown tracking and cleanup. |
| process/sync/shardblock_test.go | Adds tests validating recovery triggering, rewind selection, fallback behavior, and cooldown semantics. |
| process/sync/export_test.go | Exposes test-only helpers to observe/adjust preparedForSync, cooldown, and recovery-attempt counters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/testnet-fixes #7901 +/- ##
===================================================
Coverage 77.68% 77.69%
===================================================
Files 885 885
Lines 125828 125904 +76
===================================================
+ Hits 97745 97816 +71
- Misses 21603 21608 +5
Partials 6480 6480 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sstanculeanu
previously approved these changes
Jul 6, 2026
ssd04
previously approved these changes
Jul 6, 2026
…chain-go into fix-recover-on-sync-error
sstanculeanu
approved these changes
Jul 7, 2026
ssd04
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?