request proof only if proofByNonce missing#7904
Merged
Merged
Conversation
sstanculeanu
approved these changes
Jul 8, 2026
ssd04
reviewed
Jul 8, 2026
Comment on lines
+1224
to
+1229
| if !bp.enableEpochsHandler.IsFlagEnabledInEpoch(common.AndromedaFlag, headers[index].GetEpoch()) { | ||
| continue | ||
| } | ||
|
|
||
| _, err = bp.proofsPool.GetProofByNonce(i, shardID) | ||
| if err != nil { |
Contributor
There was a problem hiding this comment.
are these really needed? these checks are already done in requestProofIfNeeded, or is it just for checking by nonce?
Contributor
Author
There was a problem hiding this comment.
We need to check by nonce. Without this, we could request a hash that was never finalized, so no one would send the data for that hash, thus waiting indefinitely.
ssd04
approved these changes
Jul 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7904 +/- ##
==========================================
+ Coverage 76.62% 76.63% +0.01%
==========================================
Files 814 815 +1
Lines 111225 111250 +25
==========================================
+ Hits 85224 85260 +36
+ Misses 20187 20174 -13
- Partials 5814 5816 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
danidrasovean
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?