cleanup wrong type records, add tests#7907
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves quarantine header handling by actively cleaning up invalid quarantined-header cache entries and adds/extends tests to cover quarantine-related error paths in block proposal validation.
Changes:
- Refactors quarantined-header sweeping into a dedicated method and removes entries with unexpected value types.
- Adds tests for sweeping expired quarantined headers and for rejecting quarantined headers during proposal validation.
- Ensures integration test nodes also close the block tracker when shutting down.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| process/track/export_test.go | Exposes sweep method and quarantine delta constant for cross-package tests. |
| process/track/baseBlockTrack.go | Extracts sweep logic and removes wrong-type quarantined entries (with warning). |
| process/track/baseBlockTrack_test.go | Adds unit tests for sweeping behavior and wrong-type cleanup. |
| process/block/shardblockProposal_test.go | Adds test ensuring quarantined meta headers are rejected. |
| process/block/metablockProposal_test.go | Adds test ensuring quarantined shard headers are rejected in sequence checks; minor variable rename. |
| integrationTests/testProcessorNode.go | Closes BlockTracker during integration test node shutdown. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Base automatically changed from
quarantined-headers-detection
to
feat/testnet-fixes
July 9, 2026 08:43
sstanculeanu
previously approved these changes
Jul 9, 2026
ssd04
previously approved these changes
Jul 9, 2026
…ain-go into update-tests-quarantine
sstanculeanu
approved these changes
Jul 9, 2026
ssd04
approved these changes
Jul 9, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/testnet-fixes #7907 +/- ##
======================================================
+ Coverage 77.68% 77.69% +0.01%
======================================================
Files 885 885
Lines 126014 126020 +6
======================================================
+ Hits 97894 97917 +23
+ Misses 21636 21622 -14
+ Partials 6484 6481 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?