Skip to content

cleanup wrong type records, add tests#7907

Merged
AdoAdoAdo merged 4 commits into
feat/testnet-fixesfrom
update-tests-quarantine
Jul 9, 2026
Merged

cleanup wrong type records, add tests#7907
AdoAdoAdo merged 4 commits into
feat/testnet-fixesfrom
update-tests-quarantine

Conversation

@AdoAdoAdo

Copy link
Copy Markdown
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves quarantine header handling by actively cleaning up invalid quarantined-header cache entries and adds/extends tests to cover quarantine-related error paths in block proposal validation.

Changes:

  • Refactors quarantined-header sweeping into a dedicated method and removes entries with unexpected value types.
  • Adds tests for sweeping expired quarantined headers and for rejecting quarantined headers during proposal validation.
  • Ensures integration test nodes also close the block tracker when shutting down.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
process/track/export_test.go Exposes sweep method and quarantine delta constant for cross-package tests.
process/track/baseBlockTrack.go Extracts sweep logic and removes wrong-type quarantined entries (with warning).
process/track/baseBlockTrack_test.go Adds unit tests for sweeping behavior and wrong-type cleanup.
process/block/shardblockProposal_test.go Adds test ensuring quarantined meta headers are rejected.
process/block/metablockProposal_test.go Adds test ensuring quarantined shard headers are rejected in sequence checks; minor variable rename.
integrationTests/testProcessorNode.go Closes BlockTracker during integration test node shutdown.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread process/track/baseBlockTrack.go
Comment thread process/track/baseBlockTrack_test.go Outdated
Base automatically changed from quarantined-headers-detection to feat/testnet-fixes July 9, 2026 08:43
sstanculeanu
sstanculeanu previously approved these changes Jul 9, 2026
ssd04
ssd04 previously approved these changes Jul 9, 2026
@AdoAdoAdo AdoAdoAdo dismissed stale reviews from ssd04 and sstanculeanu via 4c632dc July 9, 2026 08:52
@AdoAdoAdo AdoAdoAdo merged commit a1cc8c6 into feat/testnet-fixes Jul 9, 2026
9 checks passed
@AdoAdoAdo AdoAdoAdo deleted the update-tests-quarantine branch July 9, 2026 09:19
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.69%. Comparing base (bf35753) to head (4c632dc).
⚠️ Report is 5 commits behind head on feat/testnet-fixes.

Files with missing lines Patch % Lines
process/track/baseBlockTrack.go 93.33% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           feat/testnet-fixes    #7907      +/-   ##
======================================================
+ Coverage               77.68%   77.69%   +0.01%     
======================================================
  Files                     885      885              
  Lines                  126014   126020       +6     
======================================================
+ Hits                    97894    97917      +23     
+ Misses                  21636    21622      -14     
+ Partials                 6484     6481       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants