Fix after review.

Author: andreibancioiu

server/services/constants.go

@@ -29,7 +29,7 @@ var (
 	durationAlarmThresholdAccountServiceGetAccountBalance = time.Duration(500) * time.Millisecond
 )
 
-var (
+const (
 	transactionEventSignalError                             = core.SignalErrorOperation
 	transactionEventSCDeploy                                = core.SCDeployIdentifier
 	transactionEventTransferValueOnly                       = "transferValueOnly"
@@ -51,7 +51,7 @@ var (
 	transactionEventTransferAndExecute       = "TransferAndExecute"
 )
 
-var (
+const (
 	numTopicsOfEventESDTTransfer                    = 4
 	numTopicsPerTransferOfEventMultiESDTNFTTransfer = 3
 	numTopicsOfEventESDTLocalBurn                   = 3

server/services/transactionEventsController.go

@@ -77,7 +77,8 @@ func (controller *transactionEventsController) decideEffectiveEventTransferValue
 		return nil, nil
 	}
 
-	if string(event.Data) != transactionEventDataExecuteOnDestContext && string(event.Data) != transactionEventDataAsyncCall && string(event.Data) != transactionEventTransferAndExecute {
+	eventData := string(event.Data)
+	if eventData != transactionEventDataExecuteOnDestContext && eventData != transactionEventDataAsyncCall && eventData != transactionEventTransferAndExecute {
 		// Ineffective event, since the balance change is already captured by a SCR.
 		return nil, nil
 	}