Skip to content

Update WalletConnect Provider to 6.1.5 #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radumojic merged 1 commit into from
Mar 27, 2026
Merged

Update WalletConnect Provider to 6.1.5 #1730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [[5.6.23](https://github.com/multiversx/mx-sdk-dapp/pull/1731)] - 2026-03-27

- [Update WalletConnect Provider to 6.1.5](https://github.com/multiversx/mx-sdk-dapp/pull/1730)

## [[5.6.22](https://github.com/multiversx/mx-sdk-dapp/pull/1729)] - 2026-03-17

- [Fixed account balance does not update in the UI after receiving an incoming transaction via WebSocket.
](https://github.com/multiversx/mx-sdk-dapp/pull/1729)
- [Fixed account balance does not update in the UI after receiving an incoming transaction via WebSocket.](https://github.com/multiversx/mx-sdk-dapp/pull/1729)

## [[5.6.21](https://github.com/multiversx/mx-sdk-dapp/pull/1728)] - 2026-03-11

Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@multiversx/sdk-dapp",
"version": "5.6.22",
"version": "5.6.23",
"description": "A library to hold the main logic for a dapp on the MultiversX blockchain",
"author": "MultiversX",
"license": "MIT",
Expand Down Expand Up @@ -62,7 +62,7 @@
"@multiversx/sdk-extension-provider": "5.1.2",
"@multiversx/sdk-hw-provider": "8.1.2",
"@multiversx/sdk-native-auth-client": "2.0.1",
"@multiversx/sdk-wallet-connect-provider": "6.1.4",
"@multiversx/sdk-wallet-connect-provider": "6.1.5",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While updating this dependency, I noticed a potential critical issue in src/providers/strategies/WalletConnectProviderStrategy/WalletConnectProviderStrategy.ts that could lead to an infinite loop and application instability.

In the login method, if the initial login attempt fails, it calls reconnect(). The reconnect() method itself has a catch block that recursively calls reconnect() on any failure. This will cause an infinite loop if the connection or login continues to fail (for example, if the user repeatedly rejects the connection).

Here's the problematic code:

In login():

// src/providers/strategies/WalletConnectProviderStrategy/WalletConnectProviderStrategy.ts:257
    } catch (error) {
      console.error(WalletConnectV2Error.userRejected, error);
      return await reconnect();
    }

In reconnect():

// src/providers/strategies/WalletConnectProviderStrategy/WalletConnectProviderStrategy.ts:237
      } catch {
        return await reconnect();
      }

To prevent this, I recommend removing the recursive call within the catch block of reconnect and instead re-throwing the error to be handled by the caller. This will prevent the infinite loop.

Suggested change in reconnect():

// src/providers/strategies/WalletConnectProviderStrategy/WalletConnectProviderStrategy.ts:237
      } catch (err) {
        console.error('WalletConnect reconnect failed', err);
        throw err;
      }

"@multiversx/sdk-web-wallet-cross-window-provider": "3.2.2",
"@multiversx/sdk-web-wallet-iframe-provider": "4.0.1",
"@multiversx/sdk-webview-provider": "3.2.7",
Expand Down
Loading
Loading