Skip to content

Commit cb2db2d

Browse files
committed
Fix after review
1 parent 1c35557 commit cb2db2d

3 files changed

Lines changed: 3 additions & 1 deletion

File tree

erdpy/config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,7 @@ def parse_strings_to_semver(version_strings: List[str]) -> List[semver.VersionIn
272272
versions = []
273273
for version_string in version_strings:
274274
try:
275+
# Omit the 'v' prefix of the version string
275276
version_string = version_string[1:]
276277
version = semver.VersionInfo.parse(version_string)
277278
except ValueError:

erdpy/dependencies/install.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ def install_module(key: str, tag: str = "", overwrite: bool = False):
1515
modules = get_all_deps()
1616
else:
1717
modules = [get_module_by_key(key)]
18+
1819
for module in modules:
1920
module.install(tag, overwrite)
2021

erdpy/dependencies/modules.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ def get_source_directory(self, tag: str):
113113
if tag_no_v.startswith("v"):
114114
tag_no_v = tag_no_v[1:]
115115
assert isinstance(self.repo_name, str)
116-
source_folder = self.get_directory(tag) / (self.repo_name + '-' + tag_no_v)
116+
source_folder = self.get_directory(tag) / f'{self.repo_name}-{tag_no_v}'
117117
return source_folder
118118

119119
def get_parent_directory(self) -> Path:

0 commit comments

Comments
 (0)