Governance integration#517
Merged
Merged
Conversation
Comment on lines
+3159
to
+3172
| "transactionOnNetwork": { | ||
| "nonce": 42, | ||
| "sender": "alice", | ||
| "receiver": "bob", | ||
| "...": "..." | ||
| }, | ||
| "simulation": { | ||
| "execution": { | ||
| "...": "..." | ||
| }, | ||
| "cost": { | ||
| "...": "..." | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe we should drop this (here, below). Less verbose (not applicable).
danielailie
reviewed
Jun 4, 2025
| tx.options = options | ||
| tx.gas_price = gas_price | ||
| tx.guardian = guardian_and_relayer_data.guardian_address | ||
| tx.relayer = guardian_and_relayer_data.relayer_address |
There was a problem hiding this comment.
I would extract this into a common set
tx.nonce = nonce
tx.version = version
tx.options = options
tx.gas_price = gas_price
tx.guardian = guardian_and_relayer_data.guardian_address
tx.relayer = guardian_and_relayer_data.relayer_address
as it is used in each method
Collaborator
Author
There was a problem hiding this comment.
done.
will do for other controllers as well, in a future PR.
danielailie
previously approved these changes
Jun 4, 2025
danielailie
approved these changes
Jun 5, 2025
andreibancioiu
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.