-
Notifications
You must be signed in to change notification settings - Fork 37
Environment config #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Environment config #519
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2177758
Merge branch 'main' into merge-main-26-05
popenta addec09
Merge pull request #518 from multiversx/merge-main-26-05
popenta fde5605
config cleanup
popenta afba2a8
allow users to set proxy url in config
popenta 827cd35
update gitignore
popenta e118b94
require python 3.10 or greater
popenta 1650914
Merge pull request #520 from multiversx/switch-to-python-3.10
popenta a73025d
Merge branch 'feat/configs' into environment-config
popenta b7d1ff3
add caching
popenta e066bc9
pass explorer url when logging transactions
popenta 2906430
fixes
popenta bf2f946
fix mypy error
popenta 4e029f2
move env to separate env file
popenta 693d730
Merge branch 'feat/next' into environment-config
popenta 32787af
refactoring
popenta d58ed56
Merge branch 'feat/next' into environment-config
popenta 2a5d73b
fix after review
popenta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,3 +30,5 @@ venv.bak/ | |
| typings | ||
|
|
||
| multiversx_sdk_cli/tests/testdata-out | ||
|
|
||
| .DS_store | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch sounds good. Though, about set & get, let's double check with @ccorcoveanu whether this is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getandsetsound good (also git has get and set methods for config). what I am thinking is, do we needdump? Or shouldgetwithout any arguments actually dump the active config?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getwithout args dumping the entire config sounds good. I've done it withdumpto match themxpy config dumpcommand.