codec - trait default implementation cleanup

[andrei-marinica]

Pull request overview

This PR refactors the codec traits’ default implementations by removing the default bodies of the *_or_handle_err methods (making them required) and instead providing defaults for the simpler top_encode/top_decode/dep_encode/dep_decode methods that delegate to the handler-based variants. It also updates one scenario value type to implement the new required method.

Changes:

• Make TopEncode::top_encode_or_handle_err, TopDecode::top_decode_or_handle_err, NestedEncode::dep_encode_or_handle_err, and NestedDecode::dep_decode_or_handle_err required trait methods by removing their default implementations.
• Provide/keep default implementations for top_encode/top_decode/dep_encode/dep_decode that call the handler-based variants with DefaultErrorHandler.
• Update BytesValue to implement TopEncode::top_encode_or_handle_err and adjust imports accordingly.

[github-actions]

Contract comparison - from 0097bb4 to 04c2769

Path	size	has-allocator	has-format
large-storage.wasm	1644	false	None
linked-list-repeat.wasm	6945	false	without message
map-repeat.wasm	7483	false	without message
queue-repeat.wasm	5536	false	None
set-repeat.wasm	6463	false	None
single-value-repeat.wasm	4134	false	None
vec-repeat.wasm	4826	false	None
send-tx-repeat.wasm	1279	false	None
str-repeat-mb-builder-basic.wasm	747	false	None
str-repeat.wasm	2892	false	without message
str-repeat-mb-builder-cached.wasm	1082	false	without message
very-large-storage.wasm	977	false	None
multiversx-price-aggregator-sc.wasm	17823	false	without message
multiversx-wegld-swap-sc.wasm	4393	false	None
adder.wasm	699	false	None
bonding-curve-contract.wasm	13998	false	None
check-pause.wasm	1250	false	None
crowdfunding.wasm	3513	false	None
crypto-bubbles.wasm	2508	false	None
kitty-auction.wasm	9295	false	without message
kitty-genetic-alg.wasm	3681	false	without message
kitty-ownership.wasm	13017	false	without message
crypto-zombies.wasm	9125	false	without message
digital-cash.wasm	9565	false	None
empty.wasm	244	false	None
esdt-transfer-with-fee.wasm	7376	false	without message
factorial.wasm	579	false	None
fractional-nfts.wasm	8141	false	without message
lottery.wasm	11972	false	without message
multisig-full.wasm	15012	false	without message
multisig.wasm	13368	false	without message
multisig-view.wasm	5581	false	None
nft-minter.wasm	9594	false	without message
nft-storage-prepay.wasm	2583	false	None
nft-subscription.wasm	8716	false	without message
order-book-factory.wasm	3331	false	None
order-book-pair.wasm	14176	false	None
ping-pong-egld.wasm	6332	false	None
proxy-pause.wasm	4101	false	None
rewards-distribution.wasm	9498	false	without message
seed-nft-minter.wasm	14164	false	without message
token-release.wasm	6907	false	without message
abi-tester-ev.wasm	760	false	None
abi-tester.wasm	8465	true	without message
alloc-mem-fail.wasm	17214 ➡️ 17164 🟢 (-50)	true	without message
alloc-features.wasm	21681 ➡️ 21669 🟢 (-12)	false	without message
alloc-mem-leaking.wasm	21845 ➡️ 21833 🟢 (-12)	false	without message
basic-features-small-int-bug.wasm	824	false	None
basic-features-storage-bytes.wasm	541	false	None
basic-features.wasm	87105	false	without message
big-float-features.wasm	6357	false	without message
builtin-func-features.wasm	3768	false	None
first-contract.wasm	3370	false	None
second-contract.wasm	1145	false	None
child.wasm	3937	false	without message
parent.wasm	1938	false	None
forwarder.wasm	49028	false	without message
forwarder-blind.wasm	14053	false	without message
forwarder-legacy.wasm	33700	false	without message
forwarder-raw-init-sync-call.wasm	2853	false	None
forwarder-raw-init-async-call.wasm	2295	false	None
forwarder-raw.wasm	13068	false	None
local-esdt-and-nft.wasm	12462	false	without message
mesh-node.wasm	15701	false	without message
proxy-test-first.wasm	5595	false	without message
proxy-test-second.wasm	2291	false	without message
recursive-caller.wasm	5076	false	without message
transfer-role-features.wasm	8424	false	without message
vault.wasm	8866	false	None
vault-upgrade.wasm	698	false	None
crowdfunding-erc20.wasm	4828	false	without message
erc1155.wasm	11820	false	without message
erc1155-marketplace.wasm	10699	false	without message
erc1155-user-mock.wasm	1209	false	None
erc20.wasm	1860	false	None
erc721.wasm	2232	false	None
lottery-erc20.wasm	12782	false	without message
esdt-system-sc-mock.wasm	4637	false	None
exchange-features.wasm	1494	false	None
formatted-message-features.wasm	3562	false	without message
multi-contract-alt-impl.wasm	353	false	None
multi-contract-features-view.wasm	1113	false	None
multi-contract-example-feature.wasm	680	false	None
multi-contract-features.wasm	681	false	None
panic-message-std.wasm	16074	false	with message
panic-message-features.wasm	13036	false	with message
payable-features.wasm	5708	false	None
rust-snippets-generator-test.wasm	4627	false	None
rust-testing-framework-tester.wasm	8404	false	None
forbidden-opcodes.wasm	842	false	None
scenario-tester.wasm	1374	false	None
std-contract.wasm	3469	true	without message
use-module-view.wasm	736	false	None
use-module.wasm	33106	false	without message

[Copilot]

Pull request overview

This PR refactors the codec traits’ default implementations by removing the default bodies of the *_or_handle_err methods (making them required) and instead providing defaults for the simpler top_encode/top_decode/dep_encode/dep_decode methods that delegate to the handler-based variants. It also updates one scenario value type to implement the new required method.

Changes:

• Make TopEncode::top_encode_or_handle_err, TopDecode::top_decode_or_handle_err, NestedEncode::dep_encode_or_handle_err, and NestedDecode::dep_decode_or_handle_err required trait methods by removing their default implementations.
• Provide/keep default implementations for top_encode/top_decode/dep_encode/dep_decode that call the handler-based variants with DefaultErrorHandler.
• Update BytesValue to implement TopEncode::top_encode_or_handle_err and adjust imports accordingly.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
framework/scenario/src/scenario/model/value/bytes_value.rs	Updates BytesValue’s TopEncode impl to the new required handler-based method signature.
data/codec/src/single/top_en.rs	Removes default impl for TopEncode::top_encode_or_handle_err, leaving it required; keeps top_encode delegating via DefaultErrorHandler.
data/codec/src/single/top_de.rs	Removes default impl for TopDecode::top_decode_or_handle_err, leaving it required; keeps top_decode delegating via DefaultErrorHandler.
data/codec/src/single/nested_en.rs	Removes default impl for NestedEncode::dep_encode_or_handle_err, leaving it required; keeps dep_encode delegating via DefaultErrorHandler.
data/codec/src/single/nested_de.rs	Removes default impl for NestedDecode::dep_decode_or_handle_err, leaving it required; keeps dep_decode delegating via DefaultErrorHandler.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.