Skip to content

Commit 43ffb27

Browse files
committed
Avoid undefined variable errors
1 parent b9b283e commit 43ffb27

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ const requestHandlers = {
5151
if (!reports[r.query.report]) return Boom.badRequest('invalid report (100)')
5252

5353
const missingParams = reports[r.query.report].params.filter(e => !r.query[e])
54-
if (missingParams.length) {
54+
if ( typeof missingParams !== 'undefined' ) {
5555
return Boom.badRequest(`missing required parameters: ${missingParams.join()}` + ' (101)')
5656
}
5757

@@ -386,7 +386,7 @@ function ILSWSErrorResponse (error) {
386386
return Boom.gatewayTimeout(error.message + ' (500)')
387387
default:
388388
console.log(error)
389-
if (error.response.data.messageList.length) {
389+
if ( typeof error.response.data.messageList !== 'undefined' ) {
390390
console.log(error.response.data.messageList[0].message)
391391
}
392392
return Boom.badImplementation(`ILSWS ${error.toString()}` + ' (600)')

0 commit comments

Comments
 (0)