🔥 Removed TKET dependency#519
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
=======================================
+ Coverage 90.6% 91.8% +1.2%
=======================================
Files 36 34 -2
Lines 1697 1554 -143
=======================================
- Hits 1539 1428 -111
+ Misses 158 126 -32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
simon1hofmann
added
dependencies
nquetschlich
left a comment
nquetschlich
left a comment
There was a problem hiding this comment.
Dear @simon1hofmann, thanks a lot for your effort. It already looks almost ready to merge, I just had a few minor comments.
Co-authored-by: Nils Quetschlich <nils.quetschlich@tum.de> Signed-off-by: simon1hofmann <119581649+simon1hofmann@users.noreply.github.com>
burgholzer
added
major
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| target_directory: str = "./", | ||
| target_filename: str = "", | ||
| qasm_format: str = "qasm3", | ||
| ) -> bool: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| target_directory: str = "./", | ||
| target_filename: str = "", | ||
| qasm_format: str = "qasm3", | ||
| ) -> QuantumCircuit: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| target_directory: str = "./", | ||
| target_filename: str = "", | ||
| qasm_format: str = "qasm3", | ||
| ) -> bool: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| target_directory: str = "./", | ||
| target_filename: str = "", | ||
| qasm_format: str = "qasm3", | ||
| ) -> QuantumCircuit: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| target_directory: str = "./", | ||
| target_filename: str = "", | ||
| qasm_format: str = "qasm3", | ||
| ) -> bool: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
nquetschlich
left a comment
nquetschlich
left a comment
There was a problem hiding this comment.
Thanks for the changes. I think it makes sense that @burgholzer takes a look at this PR now.
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
burgholzer
left a comment
burgholzer
left a comment
There was a problem hiding this comment.
This is looking great. Many thanks for all the work.
I merely pushed a couple of minor fix ups where I noticed that something was still slightly off.
Once CI is green. This is good to go in 🚀
4 participants
Removed all
TKETdependencies.Resolves #522