🛠️ escape paths in std::system call to support spaces on all platforms

burgholzer · burgholzer · commit 2d632c99cfe6 · 2025-12-28T18:06:54.000+01:00
Signed-off-by: burgholzer &lt;burgholzer@me.com&gt;
diff --git a/test/qir/runner/test_qir_runner.cpp b/test/qir/runner/test_qir_runner.cpp
@@ -31,7 +31,7 @@ INSTANTIATE_TEST_SUITE_P(
 TEST_P(QIRRunnerTest, QIRFile) {
   const auto& file = GetParam();
   std::ostringstream command;
-  command << EXECUTABLE_PATH << " " << file;
+  command << "\"" << EXECUTABLE_PATH << "\" \"" << file << "\"";
   const auto result = std::system(command.str().c_str());
   EXPECT_EQ(result, 0);
 }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ INSTANTIATE_TEST_SUITE_P(`
`31`	`31`	`TEST_P(QIRRunnerTest, QIRFile) {`
`32`	`32`	`const auto& file = GetParam();`
`33`	`33`	`std::ostringstream command;`
`34`		`- command << EXECUTABLE_PATH << " " << file;`
	`34`	`+ command << "\"" << EXECUTABLE_PATH << "\" \"" << file << "\"";`
`35`	`35`	`const auto result = std::system(command.str().c_str());`
`36`	`36`	`EXPECT_EQ(result, 0);`
`37`	`37`	`}`