🎨 pre-commit fixes

Author: pre-commit-ci[bot]

CMakeLists.txt

@@ -24,22 +24,15 @@ include(PackageAddTest)
 include(Cache)
 include(AddMQTCoreLibrary)
 
-# include(FetchContent)
-# FetchContent_Declare(
-#   armadillo
-#   GIT_REPOSITORY https://gitlab.com/conradsnicta/armadillo-code.git
-#   GIT_TAG 15.0.1
-# )
+# include(FetchContent) FetchContent_Declare( armadillo GIT_REPOSITORY
+# https://gitlab.com/conradsnicta/armadillo-code.git GIT_TAG 15.0.1 )
 # FetchContent_MakeAvailable(armadillo)
 find_package(Armadillo 15 REQUIRED)
 if(Armadillo_FOUND AND NOT TARGET Armadillo::Armadillo)
   add_library(Armadillo::Armadillo INTERFACE IMPORTED)
   set_target_properties(
-    Armadillo::Armadillo
-    PROPERTIES
-      INTERFACE_LINK_LIBRARIES "${ARMADILLO_LIBRARIES}"
-      INTERFACE_INCLUDE_DIRECTORIES "${ARMADILLO_INCLUDE_DIRS}"
-  )
+    Armadillo::Armadillo PROPERTIES INTERFACE_LINK_LIBRARIES "${ARMADILLO_LIBRARIES}"
+                                    INTERFACE_INCLUDE_DIRECTORIES "${ARMADILLO_INCLUDE_DIRS}")
 endif()
 
 option(BUILD_MQT_CORE_BINDINGS "Build the MQT Core Python bindings" OFF)

mlir/lib/Dialect/MQTOpt/Transforms/GateDecomposition.cpp

@@ -40,7 +40,8 @@ struct GateDecomposition final
     config.setUseTopDownTraversal(true);
 
     // Apply patterns in an iterative and greedy manner.
-    if (mlir::failed(mlir::applyPatternsGreedily(op, std::move(patterns), config))) {
+    if (mlir::failed(
+            mlir::applyPatternsGreedily(op, std::move(patterns), config))) {
       signalPassFailure();
     }
   }

mlir/lib/Dialect/MQTOpt/Transforms/GateDecompositionPattern.cpp

@@ -9,6 +9,7 @@
  */
 
 #include "Helpers.h"
+#include "d.h"
 #include "mlir/Dialect/MQTOpt/IR/MQTOptDialect.h"
 #include "mlir/Dialect/MQTOpt/Transforms/Passes.h"
 
@@ -25,8 +26,6 @@
 #include <mlir/Support/LogicalResult.h>
 #include <string>
 
-#include "d.h"
-
 namespace mqt::ir::opt {
 
 /**
@@ -48,7 +47,8 @@ struct GateDecompositionPattern final
       return mlir::failure();
     }
 
-    matrix4x4 unitaryMatrix = helpers::kroneckerProduct(identityGate, identityGate);
+    matrix4x4 unitaryMatrix =
+        helpers::kroneckerProduct(identityGate, identityGate);
     for (auto&& gate : series) {
       auto gateMatrix = getTwoQubitMatrix({.type = helpers::getQcType(gate),
                                            .parameter = {/*TODO*/},
@@ -329,10 +329,10 @@ struct GateDecompositionPattern final
 
   static std::tuple<matrix2x2, matrix2x2, fp>
   decompose_two_qubit_product_gate(matrix4x4 special_unitary) {
-      using helpers::dot;
-      using helpers::kroneckerProduct;
-      using helpers::transpose_conjugate;
-      using helpers::determinant;
+    using helpers::determinant;
+    using helpers::dot;
+    using helpers::kroneckerProduct;
+    using helpers::transpose_conjugate;
     // first quadrant
     matrix2x2 r = {special_unitary[0 * 4 + 0], special_unitary[0 * 4 + 1],
                    special_unitary[1 * 4 + 0], special_unitary[1 * 4 + 1]};
@@ -375,7 +375,7 @@ struct GateDecompositionPattern final
 
   static matrix4x4 magic_basis_transform(const matrix4x4& unitary,
                                          MagicBasisTransform direction) {
-      using helpers::dot;
+    using helpers::dot;
     constexpr matrix4x4 B_NON_NORMALIZED = {
         C_ONE,  IM,     C_ZERO, C_ZERO,  C_ZERO, C_ZERO, IM,     C_ONE,
         C_ZERO, C_ZERO, IM,     C_M_ONE, C_ONE,  M_IM,   C_ZERO, C_ZERO,
@@ -545,10 +545,10 @@ struct GateDecompositionPattern final
     static TwoQubitWeylDecomposition
     new_inner(matrix4x4 unitary_matrix, std::optional<fp> fidelity,
               std::optional<Specialization> _specialization) {
-      using helpers::dot;
       using helpers::determinant;
-      using helpers::transpose;
       using helpers::diagonal;
+      using helpers::dot;
+      using helpers::transpose;
       auto& u = unitary_matrix;
       auto det_u = determinant(u);
       auto det_pow = std::pow(det_u, static_cast<fp>(-0.25));
@@ -565,11 +565,11 @@ struct GateDecompositionPattern final
       helpers::print(m2);
 
       arma::Mat<qfp> U(4, 4);
-  for (int i = 0; i < 4; ++i) {
-    for (int j = 0; j < 4; ++j) {
-      U.at(j, i) = u_p[j * 4 + i];
-    }
-  }
+      for (int i = 0; i < 4; ++i) {
+        for (int j = 0; j < 4; ++j) {
+          U.at(j, i) = u_p[j * 4 + i];
+        }
+      }
       auto x = U.st() * U;
       std::cerr << "ARMA\n" << U.t() << "\n\n" << U << "\n\n" << x << std::endl;
 
@@ -1407,7 +1407,7 @@ struct GateDecompositionPattern final
     decomp0_inner(const TwoQubitWeylDecomposition& target) const {
       using helpers::dot;
       return {
-        dot(target.K1r, target.K2r),
+          dot(target.K1r, target.K2r),
           dot(target.K1l, target.K2l),
       };
     }

mlir/lib/Dialect/MQTOpt/Transforms/Helpers.h

@@ -40,7 +40,8 @@ constexpr qfp M_IM{0., -1.};
 namespace mqt::ir::opt::helpers {
 
 // TODO: remove
-template <std::size_t N> void print(std::array<std::complex<fp>, N> matrix, std::string s = "") {
+template <std::size_t N>
+void print(std::array<std::complex<fp>, N> matrix, std::string s = "") {
   int i{};
   if (!s.empty()) {
     llvm::errs() << "=== " << s << " ===\n";
@@ -54,7 +55,8 @@ template <std::size_t N> void print(std::array<std::complex<fp>, N> matrix, std:
   llvm::errs() << '\n';
 }
 
-template <std::size_t N> void print(std::array<fp, N> matrix, std::string s = "") {
+template <std::size_t N>
+void print(std::array<fp, N> matrix, std::string s = "") {
   int i{};
   if (!s.empty()) {
     llvm::errs() << "=== " << s << " ===\n";
@@ -375,7 +377,8 @@ auto submatrix(Container&& matrix, int rowStart, int columnStart, int numRows,
   std::vector<ValueType<Container>> result(numRows * numColumns);
   for (int i = 0; i < numColumns; ++i) {
     for (int j = 0; j < numRows; ++j) {
-      result[j * numColumns + i] = matrix[(rowStart + j) * n + (columnStart + i)];
+      result[j * numColumns + i] =
+          matrix[(rowStart + j) * n + (columnStart + i)];
     }
   }
   return result;

mlir/lib/Dialect/MQTOpt/Transforms/a.cpp

@@ -1,3 +1,13 @@
+/*
+ * Copyright (c) 2023 - 2025 Chair for Design Automation, TUM
+ * Copyright (c) 2025 Munich Quantum Software Company GmbH
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: MIT
+ *
+ * Licensed under the MIT License
+ */
+
 #include <array>
 #include <complex>
 #include <iomanip>
@@ -32,7 +42,7 @@ matrix4x4 zgemm2(matrix4x4 a, matrix4x4 b) {
   qfp z__1;
   qfp z__2;
   qfp temp;
-  qfp alpha {1.0, 0.0};
+  qfp alpha{1.0, 0.0};
   for (auto j = 0; j < i__1; ++j) {
     for (auto i__ = 0; i__ < 4; ++i__) {
       auto i__3 = i__ + j * 4;
@@ -71,18 +81,17 @@ matrix4x4 zgemm2(matrix4x4 a, matrix4x4 b) {
 }
 
 int zgemm_(char* transa, char* transb, integer* m, integer* n, integer* k,
-           doublecomplex* alpha, matrix4x4 a, integer* lda,
-           matrix4x4 b, integer* ldb, doublecomplex* beta,
-           matrix4x4& c__, integer* ldc);
+           doublecomplex* alpha, matrix4x4 a, integer* lda, matrix4x4 b,
+           integer* ldb, doublecomplex* beta, matrix4x4& c__, integer* ldc);
 matrix4x4 zgemm(matrix4x4 a, matrix4x4 b) {
   qfp alpha{1.0, 0.0};
   qfp beta{1.0, 0.0};
   int dimension = 4;
   matrix4x4 result{};
   // zgemm_("n", "n", &dimension, &dimension, &dimension, &alpha, a.data(),
   //        &dimension, b.data(), &dimension, &beta, result.data(), &dimension);
-  zgemm_("N", "N", &dimension, &dimension, &dimension, &alpha, a,
-         &dimension, b, &dimension, &beta, result, &dimension);
+  zgemm_("N", "N", &dimension, &dimension, &dimension, &alpha, a, &dimension, b,
+         &dimension, &beta, result, &dimension);
   return result;
 }
 
@@ -91,8 +100,7 @@ void d_cnjg(doublecomplex* r, doublecomplex* z) { *r = std::conj(*z); }
 /* Subroutine */ int zgemm_(char* transa, char* transb, integer* m, integer* n,
                             integer* k, doublecomplex* alpha, matrix4x4 a,
                             integer* lda, matrix4x4 b, integer* ldb,
-                            doublecomplex* beta, matrix4x4& c__,
-                            integer* ldc) {
+                            doublecomplex* beta, matrix4x4& c__, integer* ldc) {
   /* System generated locals */
   integer a_dim1, a_offset, b_dim1, b_offset, c_dim1, c_offset, i__1, i__2,
       i__3, i__4, i__5, i__6;
@@ -360,14 +368,16 @@ void d_cnjg(doublecomplex* r, doublecomplex* z) { *r = std::conj(*z); }
                       beta->imag() * c__[i__4 - c_offset].imag()),
                 z__1.imag(beta->real() * c__[i__4 - c_offset].imag() +
                           beta->imag() * c__[i__4 - c_offset].real());
-            c__[i__3 - c_offset].real(z__1.real()), c__[i__3 - c_offset].imag(z__1.imag());
+            c__[i__3 - c_offset].real(z__1.real()),
+                c__[i__3 - c_offset].imag(z__1.imag());
             /* L60: */
           }
         }
         i__2 = *k;
         for (l = 1; l <= i__2; ++l) {
           i__3 = l + j * b_dim1;
-          if (b[i__3 - b_offset].real() != 0. || b[i__3 - b_offset].imag() != 0.) {
+          if (b[i__3 - b_offset].real() != 0. ||
+              b[i__3 - b_offset].imag() != 0.) {
             i__3 = l + j * b_dim1;
             z__1.real(alpha->real() * b[i__3 - b_offset].real() -
                       alpha->imag() * b[i__3 - b_offset].imag()),
@@ -385,7 +395,8 @@ void d_cnjg(doublecomplex* r, doublecomplex* z) { *r = std::conj(*z); }
                             temp.imag() * a[i__6 - a_offset].real());
               z__1.real(c__[i__5 - c_offset].real() + z__2.real()),
                   z__1.imag(c__[i__5 - c_offset].imag() + z__2.imag());
-              c__[i__4 - c_offset].real(z__1.real()), c__[i__4 - c_offset].imag(z__1.imag());
+              c__[i__4 - c_offset].real(z__1.real()),
+                  c__[i__4 - c_offset].imag(z__1.imag());
               /* L70: */
             }
           }
@@ -421,7 +432,8 @@ void d_cnjg(doublecomplex* r, doublecomplex* z) { *r = std::conj(*z); }
                       alpha->imag() * temp.imag()),
                 z__1.imag(alpha->real() * temp.imag() +
                           alpha->imag() * temp.real());
-            c__[i__3 - c_offset].real(z__1.real()), c__[i__3 - c_offset].imag(z__1.imag());
+            c__[i__3 - c_offset].real(z__1.real()),
+                c__[i__3 - c_offset].imag(z__1.imag());
           } else {
             i__3 = i__ + j * c_dim1;
             z__2.real(alpha->real() * temp.real() -
@@ -435,7 +447,8 @@ void d_cnjg(doublecomplex* r, doublecomplex* z) { *r = std::conj(*z); }
                           beta->imag() * c__[i__4 - c_offset].real());
             z__1.real(z__2.real() + z__3.real()),
                 z__1.imag(z__2.imag() + z__3.imag());
-            c__[i__3 - c_offset].real(z__1.real()), c__[i__3 - c_offset].imag(z__1.imag());
+            c__[i__3 - c_offset].real(z__1.real()),
+                c__[i__3 - c_offset].imag(z__1.imag());
           }
           /* L110: */
         }

mlir/lib/Dialect/MQTOpt/Transforms/b.h

@@ -1,3 +1,13 @@
+/*
+ * Copyright (c) 2023 - 2025 Chair for Design Automation, TUM
+ * Copyright (c) 2025 Munich Quantum Software Company GmbH
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: MIT
+ *
+ * Licensed under the MIT License
+ */
+
 #pragma once
 
 #include "Helpers.h"
@@ -140,7 +150,8 @@ void tridiagonalization_inplace(rmatrix4x4& mat, rdiagonal4x4& hCoeffs) {
     auto updatedMatrix = bottomRightCorner(mat, remainingSize, remainingSize);
     updatedMatrix = lowerSelfadjointView(updatedMatrix);
     updatedMatrix = rankUpdate(
-        updatedMatrix, helpers::submatrix(mat, n - remainingSize, i, remainingSize, 1),
+        updatedMatrix,
+        helpers::submatrix(mat, n - remainingSize, i, remainingSize, 1),
         std::vector<fp>{hCoeffs.begin() + (n - remainingSize), hCoeffs.end()},
         -1.0);
     // update bottom right corner
@@ -369,8 +380,8 @@ void householderSequenceEval(rmatrix4x4& m_vectors,
       llvm::copy(tmp2, matrix.begin());
 
       tmp2 = helpers::add(
-          bottom, helpers::multiply(-tau, helpers::multiply(essential, tmp,
-                                                            1)));
+          bottom,
+          helpers::multiply(-tau, helpers::multiply(essential, tmp, 1)));
       // insert all rows except first row
       llvm::copy(tmp2, matrix.begin() + n);
     }

mlir/lib/Dialect/MQTOpt/Transforms/d.h

@@ -1,3 +1,13 @@
+/*
+ * Copyright (c) 2023 - 2025 Chair for Design Automation, TUM
+ * Copyright (c) 2025 Munich Quantum Software Company GmbH
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: MIT
+ *
+ * Licensed under the MIT License
+ */
+
 #pragma once
 
 #include "Helpers.h"