Skip to content

Commit d7ced80

Browse files
authored
🐛 Fix malformed include directories in exported nlohmann_json CMake targets for component-based installs (#1662) (#1663)
## Description This PR fixes the problems observed with the 3.5.0 release while updating in dependent MQT repositories. There was a malformed include directory install command, that did not even turn out to be necessary (through local testing with QCEC, QMAP, and DDSIM). This is essentially the forward port of #1662 and the `v3.5.1` release. ## Checklist <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are focused and relevant to this change. - [x] I have added appropriate tests that cover the new/changed functionality. - [x] I have updated the documentation to reflect these changes. - [x] I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals. - [x] I have added migration instructions to the upgrade guide (if needed). - [x] The changes follow the project's style guidelines and introduce no new warnings. - [x] The changes are fully tested and pass the CI checks. - [x] I have reviewed my own code changes. **If PR contains AI-assisted content:** - [x] I have disclosed the use of AI tools in the PR description as per our [AI Usage Guidelines](https://github.com/munich-quantum-toolkit/core/blob/main/docs/ai_usage.md). - [x] AI-assisted commits include an `Assisted-by: [Model Name] via [Tool Name]` footer. - [x] I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it. --------- Signed-off-by: Lukas Burgholzer <burgholzer@me.com>
1 parent 318f3d1 commit d7ced80

3 files changed

Lines changed: 26 additions & 8 deletions

File tree

CHANGELOG.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,12 @@ This project adheres to [Semantic Versioning], with the exception that minor rel
2828
- 🔥 Remove the density matrix support from the MQT Core DD package ([#1466]) ([**@burgholzer**])
2929
- 🔥 Remove `datastructures` (`ds`) (sub)library from MQT Core ([#1458]) ([**@burgholzer**])
3030

31+
## [3.5.1] - 2026-04-23
32+
33+
### Fixed
34+
35+
- 🐛 Fix malformed include directories in exported `nlohmann_json` CMake targets for component-based installs ([#1662]) ([**@burgholzer**])
36+
3137
## [3.5.0] - 2026-04-21
3238

3339
_If you are upgrading: please see [`UPGRADING.md`](UPGRADING.md#350)._
@@ -216,6 +222,8 @@ _If you are upgrading: please see [`UPGRADING.md`](UPGRADING.md#330)._
216222

217223
## [3.2.0] - 2025-07-31
218224

225+
_If you are upgrading: please see [`UPGRADING.md`](UPGRADING.md#320)._
226+
219227
### Added
220228

221229
- 🐍 Build Python 3.14 wheels ([#1076]) ([**@denialhaag**])
@@ -334,7 +342,8 @@ _📚 Refer to the [GitHub Release Notes](https://github.com/munich-quantum-tool
334342

335343
<!-- Version links -->
336344

337-
[unreleased]: https://github.com/munich-quantum-toolkit/core/compare/v3.5.0...HEAD
345+
[unreleased]: https://github.com/munich-quantum-toolkit/core/compare/v3.5.1...HEAD
346+
[3.5.1]: https://github.com/munich-quantum-toolkit/core/releases/tag/v3.5.1
338347
[3.5.0]: https://github.com/munich-quantum-toolkit/core/releases/tag/v3.5.0
339348
[3.4.1]: https://github.com/munich-quantum-toolkit/core/releases/tag/v3.4.1
340349
[3.4.0]: https://github.com/munich-quantum-toolkit/core/releases/tag/v3.4.0
@@ -353,6 +362,7 @@ _📚 Refer to the [GitHub Release Notes](https://github.com/munich-quantum-tool
353362
<!-- PR links -->
354363

355364
[#1664]: https://github.com/munich-quantum-toolkit/core/pull/1664
365+
[#1662]: https://github.com/munich-quantum-toolkit/core/pull/1662
356366
[#1652]: https://github.com/munich-quantum-toolkit/core/pull/1652
357367
[#1637]: https://github.com/munich-quantum-toolkit/core/pull/1637
358368
[#1635]: https://github.com/munich-quantum-toolkit/core/pull/1635

UPGRADING.md

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,15 @@ The `datastructures` (sub)library has been removed from the MQT Core repository.
3737
Its functionality has only ever been used in [MQT QMAP] since its inception.
3838
As a consequence, the code shall be moved to [MQT QMAP] once QMAP adopts an MQT Core version that includes this change.
3939

40+
## [3.5.1]
41+
42+
No breaking changes.
43+
44+
### Component-based CMake installs
45+
46+
Fixed exported `nlohmann_json` CMake metadata so `find_package(mqt-core CONFIG)` no longer propagates an invalid `.../COMPONENT` include directory in component-based installations.
47+
Anyone relying on an installed version of `mqt-core` shall update from `3.5.0` to `3.5.1`.
48+
4049
## [3.5.0]
4150

4251
The shared library ABI version (`SOVERSION`) is increased from `3.4` to `3.5`.
@@ -49,6 +58,9 @@ Any existing code that uses the `mqt-core` Python bindings will need to be recom
4958

5059
## [3.4.0]
5160

61+
The shared library ABI version (`SOVERSION`) is increased from `3.3` to `3.4`.
62+
Thus, consuming libraries need to update their wheel repair configuration for `cibuildwheel` to ensure the `mqt-core` libraries are properly skipped in the wheel repair step.
63+
5264
### Python wheels
5365

5466
This release contains two changes to the distributed wheels.
@@ -227,7 +239,8 @@ It also requires the `uv` library version 0.5.20 or higher.
227239

228240
<!-- Version links -->
229241

230-
[unreleased]: https://github.com/munich-quantum-toolkit/core/compare/v3.5.0...HEAD
242+
[unreleased]: https://github.com/munich-quantum-toolkit/core/compare/v3.5.1...HEAD
243+
[3.5.1]: https://github.com/munich-quantum-toolkit/core/compare/v3.5.0...v3.5.1
231244
[3.5.0]: https://github.com/munich-quantum-toolkit/core/compare/v3.4.0...v3.5.0
232245
[3.4.0]: https://github.com/munich-quantum-toolkit/core/compare/v3.3.0...v3.4.0
233246
[3.3.0]: https://github.com/munich-quantum-toolkit/core/compare/v3.2.0...v3.3.0

cmake/ExternalDependencies.cmake

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -191,12 +191,7 @@ if(MQT_CORE_JSON_INSTALL AND TARGET nlohmann_json)
191191
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
192192
COMPONENT ${MQT_CORE_TARGET_NAME}_Development)
193193

194-
install(
195-
TARGETS nlohmann_json
196-
EXPORT ${MQT_CORE_JSON_TARGETS_EXPORT_NAME}
197-
INCLUDES
198-
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
199-
COMPONENT ${MQT_CORE_TARGET_NAME}_Development)
194+
install(TARGETS nlohmann_json EXPORT ${MQT_CORE_JSON_TARGETS_EXPORT_NAME})
200195

201196
install(
202197
EXPORT ${MQT_CORE_JSON_TARGETS_EXPORT_NAME}

0 commit comments

Comments
 (0)