Skip to content

🐛 Revert change to opTypeFromString() signature #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denialhaag merged 3 commits into from
Nov 10, 2025
Merged

🐛 Revert change to opTypeFromString() signature #1300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e3627f
🐛 Revert change to opTypeFromString() signature
denialhaag Nov 10, 2025
dd54be5
Update changelog
denialhaag Nov 10, 2025
0df752b
Prepare release of v3.3.3
denialhaag Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,16 @@ This project adheres to [Semantic Versioning], with the exception that minor rel

## [Unreleased]

## [3.3.3] - 2025-11-10

### Added

- ✨ Add support for bridge gates for the neutral atom hybrid mapper ([#1293]) ([**@lsschmid**])

### Fixed

- 🐛 Revert change to `opTypeFromString()` signature made in [#1283] ([#1300]) ([**@denialhaag**])

## [3.3.2] - 2025-11-04

### Added
Expand Down Expand Up @@ -217,7 +223,8 @@ _📚 Refer to the [GitHub Release Notes](https://github.com/munich-quantum-tool

<!-- Version links -->

[unreleased]: https://github.com/munich-quantum-toolkit/core/compare/v3.3.2...HEAD
[unreleased]: https://github.com/munich-quantum-toolkit/core/compare/v3.3.3...HEAD
[3.3.3]: https://github.com/munich-quantum-toolkit/core/releases/tag/v3.3.3
[3.3.2]: https://github.com/munich-quantum-toolkit/core/releases/tag/v3.3.2
[3.3.1]: https://github.com/munich-quantum-toolkit/core/releases/tag/v3.3.1
[3.3.0]: https://github.com/munich-quantum-toolkit/core/releases/tag/v3.3.0
Expand All @@ -231,6 +238,7 @@ _📚 Refer to the [GitHub Release Notes](https://github.com/munich-quantum-tool

<!-- PR links -->

[#1300]: https://github.com/munich-quantum-toolkit/core/pull/1300
[#1293]: https://github.com/munich-quantum-toolkit/core/pull/1293
[#1287]: https://github.com/munich-quantum-toolkit/core/pull/1287
[#1283]: https://github.com/munich-quantum-toolkit/core/pull/1283
Expand Down
2 changes: 1 addition & 1 deletion include/mqt-core/ir/operations/OpType.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ inline std::ostream& operator<<(std::ostream& out, const OpType opType) {
return out << toString(opType);
}

[[nodiscard]] OpType opTypeFromString(std::string_view opType);
[[nodiscard]] OpType opTypeFromString(const std::string& opType);

inline std::istream& operator>>(std::istream& in, OpType& opType) {
std::string opTypeStr;
Expand Down
2 changes: 1 addition & 1 deletion src/ir/operations/OpType.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ static_assert(std::ranges::is_sorted(OP_NAME_TO_TYPE.cbegin(),
}));
} // namespace

OpType opTypeFromString(const std::string_view opType) {
OpType opTypeFromString(const std::string& opType) {
// clang-tidy produces a false-positive that produces a Windows compile error
// when accepted. NOLINTNEXTLINE(*-qualified-auto)
const auto it =
Expand Down
Loading