Skip to content

✅ Test translation to jeff #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
denialhaag wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

✅ Test translation to jeff #1676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d391f42
✅ Test translation to jeff
denialhaag Apr 30, 2026
b8ec0fa
Update changelog
denialhaag Apr 30, 2026
2e10078
Merge branch 'refs/heads/main' into translate-jeff
burgholzer May 4, 2026
c2ddbbc
👽 Update due to external changes
burgholzer May 4, 2026
967155e
👽 Update due to external changes
burgholzer May 4, 2026
3ec2d79
👽 Update due to external changes
burgholzer May 5, 2026
76c494d
👽 Update jeff-mlir ref
burgholzer May 5, 2026
27efa00
👽 Update jeff-mlir ref
burgholzer May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ This project adheres to [Semantic Versioning], with the exception that minor rel
### Added

- ✨ Add a `merge-single-qubit-rotation-gates` pass for merging consecutive rotation gates using quaternions ([#1407], [#1674]) ([**@J4MMlE**], [**@MatthiasReumann**])
- ✨ Add conversions between `jeff` and QCO ([#1479], [#1548], [#1565], [#1637]) ([**@denialhaag**])
- ✨ Add conversions between `jeff` and QCO ([#1479], [#1548], [#1565], [#1637], [#1676]) ([**@denialhaag**], [**@burgholzer**])
- ✨ Add a `place-and-route` pass for mapping circuits to architectures with restricted topologies ([#1537], [#1547], [#1568], [#1581], [#1583], [#1588], [#1664]) ([**@MatthiasReumann**], [**@burgholzer**])
- ✨ Add initial infrastructure for new QC and QCO MLIR dialects
([#1264], [#1330], [#1402], [#1428], [#1430], [#1436], [#1443], [#1446], [#1464], [#1465], [#1470], [#1471], [#1472], [#1474], [#1475], [#1506], [#1510], [#1513], [#1521], [#1542], [#1548], [#1550], [#1554], [#1567], [#1569], [#1570], [#1572], [#1573], [#1580], [#1602], [#1620], [#1623], [#1624], [#1626], [#1627], [#1635], [#1673], [#1675])
Expand Down Expand Up @@ -361,6 +361,7 @@ _📚 Refer to the [GitHub Release Notes](https://github.com/munich-quantum-tool

<!-- PR links -->

[#1676]: https://github.com/munich-quantum-toolkit/core/pull/1676
[#1675]: https://github.com/munich-quantum-toolkit/core/pull/1675
[#1674]: https://github.com/munich-quantum-toolkit/core/pull/1674
[#1673]: https://github.com/munich-quantum-toolkit/core/pull/1673
Expand Down
5 changes: 1 addition & 4 deletions cmake/ExternalDependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,10 @@ if(BUILD_MQT_CORE_MLIR)
list(APPEND FETCH_PACKAGES Eigen)

# Fetch jeff-mlir
set(BUILD_JEFF_MLIR_TRANSLATION
OFF
CACHE BOOL "Disable building the translation submodule of jeff-mlir")
FetchContent_Declare(
jeff-mlir
GIT_REPOSITORY https://github.com/PennyLaneAI/jeff-mlir.git
GIT_TAG v0.1.0)
GIT_TAG 78eb342e) # improve-cmake
Copy link
Copy Markdown
Member

@burgholzer burgholzer May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
GIT_TAG 78eb342e) # improve-cmake
GIT_TAG v0.1.1)

Update once the release has been created.

list(APPEND FETCH_PACKAGES jeff-mlir)
endif()

Expand Down
3 changes: 2 additions & 1 deletion mlir/unittests/Conversion/JeffRoundTrip/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ target_link_libraries(
MLIRSupportMQT
MLIRTransforms
MLIRJeffToQCO
MLIRQCOToJeff)
MLIRQCOToJeff
MLIRJeffTranslation)

mqt_mlir_configure_unittest_target(${target_name})

Expand Down
6 changes: 6 additions & 0 deletions mlir/unittests/Conversion/JeffRoundTrip/test_jeff_round_trip.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

#include <gtest/gtest.h>
#include <jeff/IR/JeffDialect.h>
#include <jeff/Translation/Deserialize.hpp>
#include <jeff/Translation/Serialize.hpp>
#include <mlir/Dialect/Arith/IR/Arith.h>
#include <mlir/Dialect/Func/IR/FuncOps.h>
#include <mlir/IR/BuiltinOps.h>
Expand Down Expand Up @@ -111,6 +113,10 @@ TEST_P(JeffRoundTripTest, ProgramEquivalence) {
printer.record(program.get(), "Canonicalized Converted jeff IR" + name);
EXPECT_TRUE(verify(*program).succeeded());

// Serialize and deserialize to ensure the jeff program is valid
auto data = serialize(*program);
program = deserialize(context.get(), data);

EXPECT_TRUE(succeeded(convertJeffToQCO(program.get())));
printer.record(program.get(), "Converted QCO IR" + name);
EXPECT_TRUE(verify(*program).succeeded());
Expand Down
Loading