test: make Discogs snapshots insensitive to JSON key order - #1006
Merged
Conversation
- compare Discogs parser snapshots as parsed JSON instead of serialized strings, so object key ordering changes no longer cause false test failures. Snapshot regeneration via `pnpm test:discogs -u` is preserved and writes stable sorted-key JSON. - also omit the volatile Discogs `community` field from fetched fixtures and remove it from the existing fixture set, since the importer does not use it and its counts change frequently.
arsinclair
force-pushed
the
test/order-independent-comparison
branch
from
July 20, 2026 14:03
b5878f5 to
8a588d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm test:discogs -unow writes stable sorted-key JSON.communityfield from fetched fixtures and remove it from the existing fixture set, since the importer does not use it and its counts change frequently.