Skip to content

Commit 3fbe5db

Browse files
committed
Apply fixes from StyleCI
1 parent 9c58626 commit 3fbe5db

3 files changed

Lines changed: 10 additions & 11 deletions

File tree

app/Http/Controllers/CustomoidController.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public function store(CustomoidRequest $request): JsonResponse
2424
if (Customoid::where('customoid_descr', $name)->where('device_id', $deviceId)->exists()) {
2525
return response()->json([
2626
'status' => 'error',
27-
'message' => "OID named <i>" . e($name) . "</i> on this device already exists",
27+
'message' => 'OID named <i>' . e($name) . '</i> on this device already exists',
2828
]);
2929
}
3030

@@ -49,13 +49,13 @@ public function store(CustomoidRequest $request): JsonResponse
4949
if ($customoid->save()) {
5050
return response()->json([
5151
'status' => 'ok',
52-
'message' => "Added OID: <i>" . e($name) . "</i>",
52+
'message' => 'Added OID: <i>' . e($name) . '</i>',
5353
]);
5454
}
5555

5656
return response()->json([
5757
'status' => 'error',
58-
'message' => "Failed to add OID: <i>" . e($name) . "</i>",
58+
'message' => 'Failed to add OID: <i>' . e($name) . '</i>',
5959
]);
6060
}
6161

@@ -98,7 +98,7 @@ public function update(CustomoidRequest $request, Customoid $customoid): JsonRes
9898
->exists()) {
9999
return response()->json([
100100
'status' => 'error',
101-
'message' => "OID named <i>" . e($name) . "</i> on this device already exists",
101+
'message' => 'OID named <i>' . e($name) . '</i> on this device already exists',
102102
]);
103103
}
104104

@@ -121,13 +121,13 @@ public function update(CustomoidRequest $request, Customoid $customoid): JsonRes
121121
if ($customoid->save()) {
122122
return response()->json([
123123
'status' => 'ok',
124-
'message' => "Edited OID: <i>" . e($name) . "</i>",
124+
'message' => 'Edited OID: <i>' . e($name) . '</i>',
125125
]);
126126
}
127127

128128
return response()->json([
129129
'status' => 'error',
130-
'message' => "Failed to edit OID <i>" . e($name) . "</i>",
130+
'message' => 'Failed to edit OID <i>' . e($name) . '</i>',
131131
]);
132132
}
133133

@@ -180,7 +180,7 @@ public function test(Request $request, ?Customoid $customoid = null): JsonRespon
180180
if (! $response->isValid()) {
181181
return response()->json([
182182
'status' => 'error',
183-
'message' => "Invalid data in SNMP reply: " . e($response->getErrorMessage() ?: 'Timeout or bad response'),
183+
'message' => 'Invalid data in SNMP reply: ' . e($response->getErrorMessage() ?: 'Timeout or bad response'),
184184
]);
185185
}
186186

@@ -210,13 +210,13 @@ public function test(Request $request, ?Customoid $customoid = null): JsonRespon
210210

211211
return response()->json([
212212
'status' => 'ok',
213-
'message' => "Test successful for <i>" . e($name) . "</i>, value " . e($rawdata) . " received",
213+
'message' => 'Test successful for <i>' . e($name) . '</i>, value ' . e($rawdata) . ' received',
214214
]);
215215
}
216216

217217
return response()->json([
218218
'status' => 'error',
219-
'message' => "Invalid data in SNMP reply, value " . e($rawdata) . " received",
219+
'message' => 'Invalid data in SNMP reply, value ' . e($rawdata) . ' received',
220220
]);
221221
}
222222
}

app/Http/Requests/CustomoidRequest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public function rules(): array
4444
];
4545

4646
// device_id is required only when creating
47-
if ($this->isMethod('post') && !$this->route('customoid')) {
47+
if ($this->isMethod('post') && ! $this->route('customoid')) {
4848
$rules['device_id'] = 'required|integer|exists:devices,device_id';
4949
}
5050

routes/web.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@
5252
use App\Http\Controllers\RoleController;
5353
use App\Http\Controllers\Select;
5454
use App\Http\Controllers\SensorController;
55-
use App\Http\Controllers\ServiceController;
5655
use App\Http\Controllers\ServiceTemplateController;
5756
use App\Http\Controllers\SettingsController;
5857
use App\Http\Controllers\SslCertificateController;

0 commit comments

Comments
 (0)