Remove duplicate rrdtool version code (librenms#19841)

Author: murrant

LibreNMS/Data/Store/Rrd.php

@@ -585,28 +585,6 @@ public static function fixedSafeDescr($descr, $length): string
         return $result . ' ';
     }
 
-    /**
-     * Run rrdtool and parse the version from the output.
-     *
-     * @return string
-     */
-    public static function version(): string
-    {
-        try {
-            $rrd = app(RrdProcess::class, ['timeout' => 10]);
-            $output = $rrd->run('--version');
-            $parts = explode(' ', $output, 3);
-
-            if (isset($parts[1])) {
-                return str_replace('1.7.01.7.0', '1.7.0', $parts[1]);
-            }
-        } catch (Exception) {
-            //
-        }
-
-        return '';
-    }
-
     /**
      * Only track update and create primarily, just put all others in an "other" bin
      *

app/Http/Controllers/AboutController.php

@@ -55,7 +55,6 @@
 use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\App;
-use LibreNMS\Data\Store\Rrd;
 use LibreNMS\Util\Http;
 use LibreNMS\Util\Version;
 
@@ -81,7 +80,7 @@ public function index(Request $request)
             'version_laravel' => App::version(),
             'version_python' => $version->python(),
             'version_webserver' => $request->server('SERVER_SOFTWARE'),
-            'version_rrdtool' => Rrd::version(),
+            'version_rrdtool' => $version->rrdtool(),
             'version_netsnmp' => $version->netSnmp(),
 
             'stat_apps' => Application::count(),