Ports sensor panels for Device overview to blade (librenms#19919)

* Ports sensor panels for Device overview to blade

* Moved sensor blade file

* Moved sensor php file

* CI Fix

* Updated based on PR feedback

Author: laf

includes/html/pages/device/overview.inc.php

@@ -35,37 +35,7 @@
 require 'overview/mempools.inc.php';
 require 'overview/storage.inc.php';
 require 'overview/toner.inc.php';
-require 'overview/sensors/charge.inc.php';
-require 'overview/sensors/temperature.inc.php';
-require 'overview/sensors/humidity.inc.php';
-require 'overview/sensors/fanspeed.inc.php';
-require 'overview/sensors/dbm.inc.php';
-require 'overview/sensors/voltage.inc.php';
-require 'overview/sensors/current.inc.php';
-require 'overview/sensors/runtime.inc.php';
-require 'overview/sensors/power.inc.php';
-require 'overview/sensors/power_consumed.inc.php';
-require 'overview/sensors/power_factor.inc.php';
-require 'overview/sensors/frequency.inc.php';
-require 'overview/sensors/load.inc.php';
-require 'overview/sensors/state.inc.php';
-require 'overview/sensors/count.inc.php';
-require 'overview/sensors/percent.inc.php';
-require 'overview/sensors/signal.inc.php';
-require 'overview/sensors/tv_signal.inc.php';
-require 'overview/sensors/bitrate.inc.php';
-require 'overview/sensors/airflow.inc.php';
-require 'overview/sensors/snr.inc.php';
-require 'overview/sensors/pressure.inc.php';
-require 'overview/sensors/cooling.inc.php';
-require 'overview/sensors/delay.inc.php';
-require 'overview/sensors/quality_factor.inc.php';
-require 'overview/sensors/chromatic_dispersion.inc.php';
-require 'overview/sensors/ber.inc.php';
-require 'overview/sensors/eer.inc.php';
-require 'overview/sensors/waterflow.inc.php';
-require 'overview/sensors/loss.inc.php';
-require 'overview/sensors/signal_loss.inc.php';
+require 'overview/sensor.inc.php';
 require 'overview/eventlog.inc.php';
 require 'overview/services.inc.php';
 require 'overview/syslog.inc.php';

includes/html/pages/device/overview/generic/sensor.inc.php

@@ -0,0 +1,73 @@
+<?php
+
+use App\Facades\LibrenmsConfig;
+use LibreNMS\Enum\Sensor;
+use LibreNMS\Util\Rewrite;
+use LibreNMS\Util\Url;
+
+// Sensor overview panels, rendered in this order. Each empty class is skipped below.
+$sensor_overview_order = [
+    Sensor::Charge,
+    Sensor::Temperature,
+    Sensor::Humidity,
+    Sensor::Fanspeed,
+    Sensor::Dbm,
+    Sensor::Voltage,
+    Sensor::Current,
+    Sensor::Runtime,
+    Sensor::Power,
+    Sensor::PowerConsumed,
+    Sensor::PowerFactor,
+    Sensor::Frequency,
+    Sensor::Load,
+    Sensor::State,
+    Sensor::Count,
+    Sensor::Percent,
+    Sensor::Signal,
+    Sensor::TvSignal,
+    Sensor::Bitrate,
+    Sensor::Airflow,
+    Sensor::Snr,
+    Sensor::Pressure,
+    Sensor::Cooling,
+    Sensor::Delay,
+    Sensor::QualityFactor,
+    Sensor::ChromaticDispersion,
+    Sensor::Ber,
+    Sensor::Eer,
+    Sensor::Waterflow,
+    Sensor::Loss,
+    Sensor::SignalLoss,
+];
+
+foreach ($sensor_overview_order as $sensor_class) {
+    $sensors = DeviceCache::getPrimary()->sensors->where('sensor_class', $sensor_class->value)->where('group', '!=', 'transceiver')->sortBy([
+        ['group', 'asc'],
+        ['sensor_descr', 'asc'],
+    ]); // cache all sensors on device and exclude transceivers
+
+    if ($sensors->isNotEmpty()) {
+        // prepare each sensor for display: normalise the description (ipmi sensors get a
+        // friendly name, all are truncated) and build the link through to the graphs page
+        $sensors->each(function ($sensor) use ($device, $sensor_class): void {
+            $descr = $sensor->poller_type == 'ipmi'
+                ? ipmiSensorName($device['hardware'], $sensor->sensor_descr)
+                : $sensor->sensor_descr;
+
+            $sensor->sensor_descr = Rewrite::shortenIfName(substr((string) $descr, 0, 48));
+            $sensor->graph_link = Url::generate([
+                'page' => 'graphs',
+                'id' => $sensor->sensor_id,
+                'type' => 'sensor_' . $sensor_class->value,
+                'from' => LibrenmsConfig::get('time.day'),
+                'to' => LibrenmsConfig::get('time.now'),
+            ]);
+        });
+
+        echo view('device.overview.sensor', [
+            'sensor_class' => $sensor_class,
+            'sensor_link' => route('device', ['device' => DeviceCache::getPrimary()->device_id, 'tab' => 'health', 'vars' => 'metric=' . $sensor_class->value]),
+            'groupedSensors' => $sensors->groupBy('group'),
+        ]);
+    }
+}