From f8f9005db64d141457f573763970e6288cebc9aa Mon Sep 17 00:00:00 2001
From: StyleCI Bot <bot@styleci.io>
Date: Wed, 1 Jul 2026 14:25:19 +0000
Subject: [PATCH] Apply fixes from StyleCI

---
 LibreNMS/Data/Graphing/AbstractGraph.php             |  2 ++
 .../Data/Graphing/Builders/MultiLineGraphBuilder.php |  9 +++++++++
 .../Builders/MultiSimplexSeparatedGraphBuilder.php   | 12 ++++++++++++
 LibreNMS/Data/Graphing/Device/ProcessorGraph.php     |  2 ++
 LibreNMS/Data/Graphing/GraphFactory.php              |  3 ++-
 LibreNMS/Data/Graphing/LegacyGraph.php               |  9 ++++++++-
 LibreNMS/Exceptions/InvalidGraph.php                 |  9 +++++----
 LibreNMS/Interfaces/Data/Graphing/GraphInterface.php |  6 ++++++
 app/Console/Commands/GraphDetail.php                 |  9 ++++-----
 9 files changed, 50 insertions(+), 11 deletions(-)

diff --git a/LibreNMS/Data/Graphing/AbstractGraph.php b/LibreNMS/Data/Graphing/AbstractGraph.php
index e4a9fe9f24..1b0392d9e4 100644
--- a/LibreNMS/Data/Graphing/AbstractGraph.php
+++ b/LibreNMS/Data/Graphing/AbstractGraph.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * AbstractGraph.php
  *
@@ -53,6 +54,7 @@ public function fill(array $vars): self
                 }
             }
         }
+
         return $this;
     }
 }
diff --git a/LibreNMS/Data/Graphing/Builders/MultiLineGraphBuilder.php b/LibreNMS/Data/Graphing/Builders/MultiLineGraphBuilder.php
index f1d8a6ea12..591558b083 100644
--- a/LibreNMS/Data/Graphing/Builders/MultiLineGraphBuilder.php
+++ b/LibreNMS/Data/Graphing/Builders/MultiLineGraphBuilder.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * MultiLineGraphBuilder.php
  *
@@ -44,42 +45,49 @@ class MultiLineGraphBuilder
     public function unitText(string $unitText): self
     {
         $this->unitText = $unitText;
+
         return $this;
     }
 
     public function units(string $units): self
     {
         $this->units = $units;
+
         return $this;
     }
 
     public function colours(string $colours): self
     {
         $this->colours = $colours;
+
         return $this;
     }
 
     public function scaleMin(float $scaleMin): self
     {
         $this->scaleMin = $scaleMin;
+
         return $this;
     }
 
     public function scaleMax(float $scaleMax): self
     {
         $this->scaleMax = $scaleMax;
+
         return $this;
     }
 
     public function noTotal(bool $noTotal = true): self
     {
         $this->nototal = $noTotal;
+
         return $this;
     }
 
     public function descrLen(int $descrLen): self
     {
         $this->descrLen = $descrLen;
+
         return $this;
     }
 
@@ -101,6 +109,7 @@ public function addDataset(
             'areacolour' => $areaColour,
             'invert' => $invert,
         ];
+
         return $this;
     }
 
diff --git a/LibreNMS/Data/Graphing/Builders/MultiSimplexSeparatedGraphBuilder.php b/LibreNMS/Data/Graphing/Builders/MultiSimplexSeparatedGraphBuilder.php
index 66740948a5..22f3ce50b5 100644
--- a/LibreNMS/Data/Graphing/Builders/MultiSimplexSeparatedGraphBuilder.php
+++ b/LibreNMS/Data/Graphing/Builders/MultiSimplexSeparatedGraphBuilder.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * MultiSimplexSeparatedGraphBuilder.php
  *
@@ -47,60 +48,70 @@ class MultiSimplexSeparatedGraphBuilder
     public function unitText(string $unitText): self
     {
         $this->unitText = $unitText;
+
         return $this;
     }
 
     public function totalUnits(string $totalUnits): self
     {
         $this->totalUnits = $totalUnits;
+
         return $this;
     }
 
     public function colours(string $colours): self
     {
         $this->colours = $colours;
+
         return $this;
     }
 
     public function scaleMin(float $scaleMin): self
     {
         $this->scaleMin = $scaleMin;
+
         return $this;
     }
 
     public function scaleMax(float $scaleMax): self
     {
         $this->scaleMax = $scaleMax;
+
         return $this;
     }
 
     public function divider(float $divider): self
     {
         $this->divider = $divider;
+
         return $this;
     }
 
     public function multiplier(float $multiplier): self
     {
         $this->multiplier = $multiplier;
+
         return $this;
     }
 
     public function textOrig(bool $textOrig = true): self
     {
         $this->textOrig = $textOrig;
+
         return $this;
     }
 
     public function noTotal(bool $noTotal = true): self
     {
         $this->nototal = $noTotal;
+
         return $this;
     }
 
     public function descrLen(int $descrLen): self
     {
         $this->descrLen = $descrLen;
+
         return $this;
     }
 
@@ -116,6 +127,7 @@ public function addDataset(
             'descr' => $description,
             'colour' => $colour,
         ];
+
         return $this;
     }
 
diff --git a/LibreNMS/Data/Graphing/Device/ProcessorGraph.php b/LibreNMS/Data/Graphing/Device/ProcessorGraph.php
index 63f0d03fef..f131cbe93f 100644
--- a/LibreNMS/Data/Graphing/Device/ProcessorGraph.php
+++ b/LibreNMS/Data/Graphing/Device/ProcessorGraph.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * ProcessorGraph.php
  *
@@ -71,6 +72,7 @@ public function getRrdFiles(): array
         foreach ($this->processors as $proc) {
             $files[] = Rrd::name($this->device->hostname, ['processor', $proc->processor_type, $proc->processor_index]);
         }
+
         return $files;
     }
 
diff --git a/LibreNMS/Data/Graphing/GraphFactory.php b/LibreNMS/Data/Graphing/GraphFactory.php
index bab8ad240b..0e9a7f99a2 100644
--- a/LibreNMS/Data/Graphing/GraphFactory.php
+++ b/LibreNMS/Data/Graphing/GraphFactory.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * GraphFactory.php
  *
@@ -45,7 +46,7 @@ public function graphFor(string $name, array $vars = []): GraphInterface
         $vars['type'] ??= $name;
 
         // Look for a modern class, e.g. LibreNMS\Data\Graphing\Device\ProcessorSeparateGraph
-        $className = "LibreNMS\\Data\\Graphing\\" . ucfirst($type) . "\\" . \Illuminate\Support\Str::studly($subtype) . "Graph";
+        $className = 'LibreNMS\\Data\\Graphing\\' . ucfirst($type) . '\\' . \Illuminate\Support\Str::studly($subtype) . 'Graph';
         if (class_exists($className)) {
             return app($className, ['vars' => $vars]);
         }
diff --git a/LibreNMS/Data/Graphing/LegacyGraph.php b/LibreNMS/Data/Graphing/LegacyGraph.php
index b48ec0d1d1..01ccb10d13 100644
--- a/LibreNMS/Data/Graphing/LegacyGraph.php
+++ b/LibreNMS/Data/Graphing/LegacyGraph.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * LegacyGraph.php
  *
@@ -29,6 +30,7 @@
 use App\Models\Device;
 use App\Models\Port;
 use LibreNMS\Exceptions\InvalidGraph;
+
 use function base_path;
 
 class LegacyGraph extends AbstractGraph
@@ -47,6 +49,7 @@ class LegacyGraph extends AbstractGraph
 
     /**
      * @param  array<string, scalar>  $vars
+     *
      * @throws InvalidGraph
      */
     public function __construct(
@@ -103,6 +106,7 @@ private function load(): void
 
         if (! $auth) {
             $this->loaded = true;
+
             return;
         }
 
@@ -144,19 +148,21 @@ private function load(): void
     public function authorize(): bool
     {
         $this->load();
+
         return $this->authorized;
     }
 
-
     public function definition(GraphParameters $graph_params): array
     {
         $this->load();
+
         return $this->rrdOptions;
     }
 
     public function getPageTitle(): string
     {
         $this->load();
+
         return $this->pageTitle ?? $this->getGraphTitle();
     }
 
@@ -178,6 +184,7 @@ public function getGraphTitle(): string
     public function getRrdFiles(): array
     {
         $this->load();
+
         return $this->rrdFiles;
     }
 }
diff --git a/LibreNMS/Exceptions/InvalidGraph.php b/LibreNMS/Exceptions/InvalidGraph.php
index 6bb3ff163f..99bde5b542 100644
--- a/LibreNMS/Exceptions/InvalidGraph.php
+++ b/LibreNMS/Exceptions/InvalidGraph.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * InvalidGraph.php
  *
@@ -29,8 +30,8 @@
 
 class InvalidGraph extends RrdException
 {
-public function __construct(string $message = "", int $code = 0, ?Throwable $previous = null)
-{
-    parent::__construct($message ?: "Invalid Graph", $code, $previous);
-}
+    public function __construct(string $message = '', int $code = 0, ?Throwable $previous = null)
+    {
+        parent::__construct($message ?: 'Invalid Graph', $code, $previous);
+    }
 }
diff --git a/LibreNMS/Interfaces/Data/Graphing/GraphInterface.php b/LibreNMS/Interfaces/Data/Graphing/GraphInterface.php
index eb73dec086..f4a0540ede 100644
--- a/LibreNMS/Interfaces/Data/Graphing/GraphInterface.php
+++ b/LibreNMS/Interfaces/Data/Graphing/GraphInterface.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * GraphInterface.php
  *
@@ -30,9 +31,14 @@
 interface GraphInterface
 {
     public function authorize(): bool;
+
     public function validation(): array;
+
     public function definition(GraphParameters $graph_params): array;
+
     public function getPageTitle(): string;
+
     public function getGraphTitle(): string;
+
     public function getRrdFiles(): array;
 }
diff --git a/app/Console/Commands/GraphDetail.php b/app/Console/Commands/GraphDetail.php
index 7f6c1ec554..d5af96d51e 100644
--- a/app/Console/Commands/GraphDetail.php
+++ b/app/Console/Commands/GraphDetail.php
@@ -24,11 +24,10 @@ public function handle(GraphFactory $graphs): int
         $this->line("Type: $graph->type");
         $this->line("Subtype: $graph->subtype");
         $this->line('Authorized: ' . ($graph->authorize() ? 'true' : 'false'));
-        $this->line("Graph Title: " . $graph->getGraphTitle());
-        $this->line("Page Title: " . substr($graph->getPageTitle(), 0, 80));
-        $this->line("Rrd Files: " . implode(', ', array_map(fn($f) => basename($f), $graph->getRrdFiles())));
-        $this->line("Definition: " . substr(implode(' ', $graph->definition()), 80));
-
+        $this->line('Graph Title: ' . $graph->getGraphTitle());
+        $this->line('Page Title: ' . substr($graph->getPageTitle(), 0, 80));
+        $this->line('Rrd Files: ' . implode(', ', array_map(fn ($f) => basename($f), $graph->getRrdFiles())));
+        $this->line('Definition: ' . substr(implode(' ', $graph->definition()), 80));
 
         return 0;
     }