Skip to content

Commit cdd1187

Browse files
authored
Docker build fixes (#247)
Fixes errors arising in PyDesigner installation due to CMake
1 parent db97d29 commit cdd1187

4 files changed

Lines changed: 5 additions & 99 deletions

File tree

docker/Dockerfile_develop

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ RUN rm /bin/sh && ln -s /bin/bash /bin/sh
6161

6262
# Clone PyDesigner
6363
RUN mkdir -p /tmp/PyDesigner
64+
RUN pip3 install cmake
6465
RUN git clone -b develop --single-branch https://github.com/m-ama/PyDesigner.git /tmp/PyDesigner
6566
RUN pip3 install /tmp/PyDesigner
6667
RUN echo "alias python=python3" >> ~/.bashrc && source ~/.bashrc

docker/Dockerfile_latest

Lines changed: 0 additions & 96 deletions
This file was deleted.

docker/Dockerfile_release

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@ RUN apt-get update && \
4242
nano \
4343
software-properties-common \
4444
python2.7 python-pip \
45-
python3-pip \
46-
jq
45+
python3-pip
4746

4847
# Install MRTRIX3 dependencies
4948
RUN apt-get install -y --no-install-recommends \
@@ -62,7 +61,9 @@ RUN rm /bin/sh && ln -s /bin/bash /bin/sh
6261

6362
# Clone PyDesigner
6463
ADD install_pydesigner_release /tmp/install_pydesigner_release
64+
RUN sed -i 's/\r//g' /tmp/install_pydesigner_release
6565
RUN chmod +x /tmp/install_pydesigner_release && bash /tmp/install_pydesigner_release
66+
RUN pip3 install cmake
6667
RUN cd /tmp/PyDesigner && pip3 install .
6768
RUN echo "alias python=python3" >> ~/.bashrc && source ~/.bashrc
6869
RUN echo "alias pip=pip3" >> ~/.bashrc && source ~/.bashrc

docker/install_pydesigner_release

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/bin/bash
22
# Downloads and extractslatest release PyDesigner into /tmp/PyDesigner
33
mkdir -p /tmp/PyDesigner
4-
export URL=$(curl -s https://api.github.com/repos/m-ama/PyDesigner/releases | jq -r '.[0] | .tarball_url')
4+
export URL=$(curl -s https://api.github.com/repos/m-ama/PyDesigner/releases/latest | grep "tarball" | cut -d '"' -f 4)
55
wget -q -O - $URL | tar -xzvf - -C /tmp/PyDesigner --strip 1

0 commit comments

Comments
 (0)