Skip to content

Commit ea7a3c4

Browse files
authored
Fix b-value rounding to integer (#251)
* Fix max shell int rounding * Update documentation
1 parent c205880 commit ea7a3c4

3 files changed

Lines changed: 22 additions & 3 deletions

File tree

CHANGELOG.rst

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,24 @@ Changelog
44
All notable changes to this project will be documented in this file or
55
page
66

7+
`v1.0-RC9`_
8+
-----------
9+
10+
Mar 16, 2021
11+
12+
**Added**:
13+
14+
* None
15+
16+
**Changed**
17+
18+
* B-values are first rounded to a float insted of integer directly to
19+
prevent errors in preprocessing
20+
21+
**Removed**
22+
23+
* None
24+
725
`v1.0-RC8`_
826
-----------
927

@@ -124,6 +142,7 @@ Sep 22, 2020
124142
Sep 21, 2020
125143

126144
**Added**:
145+
127146
* FBI fODF map for FBI tractography. Users may use MRTrix3
128147
to further process this file.
129148
* Variable maximum spherical harmonic degree to improve
@@ -312,6 +331,7 @@ Initial port of MATLAB code to Python. 200,000,000,000 BCE
312331

313332
.. Links
314333
334+
.. _v1.0-RC9: https://github.com/m-ama/PyDesigner/releases/tag/v1.0-RC9
315335
.. _v1.0-RC8: https://github.com/m-ama/PyDesigner/releases/tag/v1.0-RC8
316336
.. _v1.0-RC7: https://github.com/m-ama/PyDesigner/releases/tag/v1.0-RC7
317337
.. _v1.0-RC6: https://github.com/m-ama/PyDesigner/releases/tag/v1.0-RC6

designer/info.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
)
1111
)
1212
__packagename__ = 'PyDesigner'
13-
__version__='v1.0-RC8'
13+
__version__='v1.0-RC9'
1414
__author__ = 'PyDesigner developers'
1515
__copyright__ = 'Copyright 2020, PyDesigner developers, MUSC Advanced Image Analysis (MAMA)'
1616
__credits__ = [

designer/preprocessing/mrinfoutil.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -440,8 +440,7 @@ def max_shell(path):
440440
console = [s.split(' ') for s in console]
441441
console = [item for sublist in console for item in sublist]
442442
console = list(filter(None, console))
443-
console = [round(int(s)) for s in console]
444-
print(console)
443+
console = [int(round(float(s))) for s in console]
445444
return max(console)
446445

447446
def is_fullsphere(path):

0 commit comments

Comments
 (0)