Add support for articulations

Author: mike-spa

src/engraving/rendering/score/stavesharinglayout.cpp

@@ -261,6 +261,10 @@ bool StaveSharingLayout::isUnison(track_idx_t prevTrack, track_idx_t nextTrack,
                 return false;
             }
         }
+
+        if (!checkArticulationsForSameVoice(c1, c2)) {
+            return false;
+        }
     }
 
     for (Segment* segment : ctx.allSegments) {
@@ -348,6 +352,10 @@ bool StaveSharingLayout::canGoToSameVoice(track_idx_t prevTrack, track_idx_t nex
 
             potentialUnisonNotes.push_back(n2);
         }
+
+        if (!checkArticulationsForSameVoice(c1, c2)) {
+            return false;
+        }
     }
 
     for (Segment* segment : ctx.allSegments) {
@@ -512,6 +520,26 @@ bool StaveSharingLayout::checkSpannersForSameVoice(track_idx_t prevTrack, track_
     return true;
 }
 
+bool StaveSharingLayout::checkArticulationsForSameVoice(Chord* chord1, Chord* chord2)
+{
+    const std::vector<Articulation*>& articulations1 = chord1->articulations();
+    const std::vector<Articulation*>& articulations2 = chord2->articulations();
+
+    if (articulations1.size() != articulations2.size()) {
+        return false;
+    }
+
+    for (size_t i = 0; i < articulations1.size(); ++i) {
+        Articulation* art1 = articulations1[i];
+        Articulation* art2 = articulations2[i];
+        if (art1->subtype() != art2->subtype()) {
+            return false;
+        }
+    }
+
+    return true;
+}
+
 bool StaveSharingLayout::canGoToSameStave(track_idx_t prevTrack, track_idx_t nextTrack,
                                           StaveSharingContext& ctx)
 {
@@ -626,6 +654,10 @@ void StaveSharingLayout::disconnectAll(SharedPart* p, StaveSharingContext& ctx)
                         EngravingItem::disconnectAllOriginItems(spannerBack);
                     }
                 }
+
+                for (Articulation* art : toChord(cr)->articulations()) {
+                    EngravingItem::disconnectAllOriginItems(art);
+                }
             }
         }
     }
@@ -741,7 +773,34 @@ void StaveSharingLayout::makeSharedChordRests(SharedPart* p, StaveSharingContext
             EngravingItem::connectSharedItem(sharedNote, originNote);
 
             makeSharedTiesAndNoteSpanners(originNote, sharedNote);
+
+            makeSharedArticulations(originChord, sharedChord);
+        }
+    }
+}
+
+void StaveSharingLayout::makeSharedArticulations(Chord* originChord, Chord* sharedChord)
+{
+    Score* score = originChord->score();
+
+    for (Articulation* originArt : originChord->articulations()) {
+        Articulation* sharedArt = nullptr;
+        for (Articulation* possibleSharedArt : sharedChord->articulations()) {
+            if (possibleSharedArt->subtype() == originArt->subtype()) {
+                sharedArt = possibleSharedArt;
+                break;
+            }
         }
+
+        if (!sharedArt) {
+            sharedArt = originArt->clone();
+            sharedArt->setTrack(sharedChord->track());
+            sharedArt->setParent(sharedChord);
+
+            score->undoAddElement(sharedArt);
+        }
+
+        EngravingItem::connectSharedItem(sharedArt, originArt);
     }
 }
 
@@ -1010,6 +1069,14 @@ void StaveSharingLayout::cleanup(SharedPart* p, StaveSharingContext& ctx)
 
             if (cr->isChord()) {
                 Chord* c = toChord(cr);
+
+                std::vector<Articulation*> articulations = c->articulations(); // copy because may be removed
+                for (Articulation* art : articulations) {
+                    if (art->originItems().empty()) {
+                        score->undoRemoveElement(art);
+                    }
+                }
+
                 std::vector<Note*> notes = c->notes();     // copy because may be removed
                 for (Note* note : notes) {
                     if (Tie* tieBack = note->tieBack(); tieBack && tieBack->originItems().empty()) {

src/engraving/rendering/score/stavesharinglayout.h

@@ -66,6 +66,7 @@ class StaveSharingLayout
     static bool checkAnnotationsForSameVoice(Segment* segment, track_idx_t prevTrack, track_idx_t nextTrack);
     static bool checkNoteSpannersForUnison(const Note* note1, const Note* note2);
     static bool checkSpannersForSameVoice(track_idx_t prevTrack, track_idx_t nextTrack, StaveSharingContext& ctx);
+    static bool checkArticulationsForSameVoice(Chord* chord1, Chord* chord2);
 
     static bool canGoToSameStave(track_idx_t prevTrack, track_idx_t nextTrack, StaveSharingContext& ctx);
 
@@ -75,6 +76,7 @@ class StaveSharingLayout
 
     static void makeSharedNotation(SharedPart* p, StaveSharingContext& ctx);
     static void makeSharedChordRests(SharedPart* p, StaveSharingContext& ctx);
+    static void makeSharedArticulations(Chord* originChord, Chord* sharedChord);
     static void makeSharedTiesAndNoteSpanners(Note* originNote, Note* sharedNote);
     static void makeSharedAnnotations(SharedPart* p, StaveSharingContext& ctx);
     static void makeSharedSpanners(SharedPart* p, StaveSharingContext& ctx);