fixed crash on move selection

Author: igorkorsukov

.github/workflows/build_macos.yml

@@ -1,7 +1,7 @@
 name: 'Build: macOS'
 
 on:
-  pull_request:
+  #pull_request:
   workflow_dispatch:
     inputs:
       build_mode:

.github/workflows/build_windows.yml

@@ -1,7 +1,7 @@
 name: 'Build: Windows'
 
 on:
-  pull_request:
+  #pull_request:
   workflow_dispatch:
     inputs:
       platforms:

.github/workflows/build_without_qt.yml

@@ -1,7 +1,7 @@
 name: 'Build: Without Qt'
 
 on:
-  pull_request:
+  #pull_request:
   workflow_dispatch:
 
 jobs:

.github/workflows/check_codestyle.yml

@@ -1,7 +1,7 @@
 name: 'Check: Codestyle'
 
 on:
-  pull_request:
+  #pull_request:
   workflow_dispatch:
 
 jobs:

.github/workflows/check_unit_tests.yml

@@ -1,7 +1,7 @@
 name: 'Check: Unit Tests (utest)'
 
 on:
-  pull_request:
+  #pull_request:
   workflow_dispatch:
     inputs:
       code_coverage:

.github/workflows/check_visual_tests.yml

@@ -1,7 +1,7 @@
 name: 'Check: Visual Tests (vtest)'
 
 on:
-  pull_request:
+  #pull_request:
   workflow_dispatch:
     inputs:
       use_qt69:

src/engraving/dom/engravingitem.cpp

@@ -1672,19 +1672,27 @@ bool EngravingItem::isSystemObjectBelowBottomStaff() const
 
 EngravingItem* EngravingItem::findAncestor(ElementType t)
 {
+    LOGDA() << "this: " << this;
     EngravingItem* e = this;
     while (e && e->type() != t) {
+        e->increment();
         e = e->parentItem();
+        LOGDA() << "parentItem: " << e;
     }
+    LOGDA() << "return parentItem: " << e;
     return e;
 }
 
 const EngravingItem* EngravingItem::findAncestor(ElementType t) const
 {
+    LOGDA() << "this: " << this;
     const EngravingItem* e = this;
     while (e && e->type() != t) {
+        e->increment();
         e = e->parentItem();
+        LOGDA() << "parentItem: " << e;
     }
+    LOGDA() << "return parentItem: " << e;
     return e;
 }
 

src/engraving/dom/engravingitem.h

@@ -171,6 +171,9 @@ class EngravingItem : public EngravingObject
 
     void deleteLater();
 
+    mutable int m_increment = 0;
+    void increment() const { m_increment++; }
+
     EngravingItem* parentItem(bool explicitParent = true) const;
     EngravingItemList childrenItems(bool all = false) const;
 

src/notation/internal/notationinteraction.cpp

@@ -4083,14 +4083,26 @@ void NotationInteraction::moveElementSelection(MoveDirection d)
 
     // VBoxes are not included in horizontal layouts - skip over them (and their contents) when moving selections...
     const auto nextNonVBox = [this, isLeftDirection](EngravingItem* currElem) -> EngravingItem* {
+        LOGDA() << "currElem: " << currElem;
+
+        IF_ASSERT_FAILED(currElem) {
+            return nullptr;
+        }
+
         while (const EngravingItem* vBox = currElem->findAncestor(ElementType::VBOX)) {
+            LOGDA() << "vBox: " << vBox;
             currElem = isLeftDirection ? toVBox(vBox)->prevMM() : toVBox(vBox)->nextMM();
             if (currElem && currElem->isMeasure()) {
                 const ChordRest* cr = score()->selection().currentCR();
                 const staff_idx_t si = cr ? cr->staffIdx() : 0;
                 Measure* mb = toMeasure(currElem);
                 currElem = isLeftDirection ? mb->prevElementStaff(si, currElem) : mb->nextElementStaff(si, currElem);
             }
+
+            if (!currElem) {
+                break;
+            }
+            LOGDA() << "end of while";
         }
         return currElem;
     };