Commit ab146d9
committed
Fix Preferences apply silently discarding changes when a page fails to instantiate
Guard obj before calling apply() in PreferencesDialog to prevent a TypeError on
undefined from corrupting the ok accumulator. Also null-safe parent binding in
PreferencesPage to avoid the root cause during instantiation.
Fixes: #338411 parent d402227 commit ab146d9
2 files changed
Lines changed: 4 additions & 2 deletions
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
185 | | - | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
186 | 188 | | |
187 | 189 | | |
188 | 190 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
0 commit comments