Skip to content

Update default inverted score colors and allow customization #34153

Description

@avvvvve

Task

Step 1

Right now, the engraving color in the score editor is fixed to black in regular mode and a light grey when the score is inverted. We should allow the user to customize this color.

  • Add 'Engraving color' as a customizable option in Preferences > Appearance > Page. This option affects the appearance of all notation elements in the score editor, but should not affect their printed color at all.
  • Also, rename the 'Color' radio button in this section to 'Page color'.
Image

The Publish tab should retain its existing behavior, showing the score in black & white (or with any actual engraving color changes) as it will be printed, ignoring whether the score will be inverted or not.

Step 2

Update the default page background color and engraving color when the score is inverted to these new colors:

  • Engraving color: #CBCBCD
  • Page color: #141416

Right now, the contrast is too high.

Step 3

When the score is inverted, enable the page color and engraving color fields so they can be customized. The colors in these fields should change depending on whether or not the score is currently inverted, using the logic in the table below (which is already implemented, though the page color field is not currently enabled when inverted).

Theme Invert score colors Only invert score in dark theme Page color / Engraving color
Light Off N/A (Disabled) Light page / Black engraving
Light On (Inverted) Off Dark page / Light engraving
Light On (Inverted) On Light page / Black engraving
Dark Off N/A (Disabled) Light page / Black engraving
Dark On (Inverted) Off Dark page / Light engraving
Dark On (Inverted) On Dark page / Light engraving

Metadata

Metadata

Assignees

Labels

Type

Fields

No fields configured for Task.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions