Skip to content

Fixed crash on move selection. 4.6 #29525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DmitryArefiev merged 1 commit into from
Aug 28, 2025
Merged

Fixed crash on move selection. 4.6 #29525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/notation/internal/notationinteraction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4083,6 +4083,10 @@ void NotationInteraction::moveElementSelection(MoveDirection d)

// VBoxes are not included in horizontal layouts - skip over them (and their contents) when moving selections...
const auto nextNonVBox = [this, isLeftDirection](EngravingItem* currElem) -> EngravingItem* {
IF_ASSERT_FAILED(currElem) {
return nullptr;
}

while (const EngravingItem* vBox = currElem->findAncestor(ElementType::VBOX)) {
currElem = isLeftDirection ? toVBox(vBox)->prevMM() : toVBox(vBox)->nextMM();
if (currElem && currElem->isMeasure()) {
Expand All @@ -4091,7 +4095,12 @@ void NotationInteraction::moveElementSelection(MoveDirection d)
Measure* mb = toMeasure(currElem);
currElem = isLeftDirection ? mb->prevElementStaff(si, currElem) : mb->nextElementStaff(si, currElem);
}

if (!currElem) {

@igorkorsukov igorkorsukov Aug 28, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem was that currElem could become null, and we called the method (currElem->findAncestor(ElementType::VBOX)) on a null pointer in while

break;
}
}

return currElem;
};

Expand Down
Loading