From b9cafb63ca6f63c06e7287b95e258546cf64bcd3 Mon Sep 17 00:00:00 2001 From: Manolo Carrasco Date: Tue, 16 Jun 2026 09:27:49 +0200 Subject: [PATCH] Fix Preferences apply silently discarding changes when a page fails to instantiate Guard obj before calling apply() in PreferencesDialog to prevent a TypeError on undefined from corrupting the ok accumulator. Also null-safe parent binding in PreferencesPage to avoid the root cause during instantiation. Fixes: #33841 --- src/preferences/qml/MuseScore/Preferences/PreferencesDialog.qml | 2 +- src/preferences/qml/MuseScore/Preferences/PreferencesPage.qml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/preferences/qml/MuseScore/Preferences/PreferencesDialog.qml b/src/preferences/qml/MuseScore/Preferences/PreferencesDialog.qml index 7098b75d82c26..aac6ef53e3996 100644 --- a/src/preferences/qml/MuseScore/Preferences/PreferencesDialog.qml +++ b/src/preferences/qml/MuseScore/Preferences/PreferencesDialog.qml @@ -182,7 +182,7 @@ StyledDialogView { for (var i in pages) { var page = pages[i] var obj = root.prv.pagesObjects[page.id] - ok &= obj.apply() + ok = obj && ok & obj.apply() } if (ok) { diff --git a/src/preferences/qml/MuseScore/Preferences/PreferencesPage.qml b/src/preferences/qml/MuseScore/Preferences/PreferencesPage.qml index 39003a9bc2e61..eb1c6930016f4 100644 --- a/src/preferences/qml/MuseScore/Preferences/PreferencesPage.qml +++ b/src/preferences/qml/MuseScore/Preferences/PreferencesPage.qml @@ -27,7 +27,7 @@ import Muse.UiComponents Rectangle { id: root - height: parent.height + height: parent ? parent.height : 0 color: ui.theme.backgroundSecondaryColor default property alias contentData: content.data