Skip to content

Fix Preferences apply silently discarding changes when a page fails to instantiate #33842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manolo wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Fix Preferences apply silently discarding changes when a page fails to instantiate #33842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/preferences/qml/MuseScore/Preferences/PreferencesDialog.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ StyledDialogView {
for (var i in pages) {
var page = pages[i]
var obj = root.prv.pagesObjects[page.id]
ok &= obj.apply()
ok = obj && ok & obj.apply()

@RomanPudashkin RomanPudashkin Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better fix would be not to add these invalid objects to the list, but this is ok for now

@RomanPudashkin RomanPudashkin Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I think there is a bug here, we will never call root.hide() if one of the objects is invalid. Instead, we should do this:

if (obj) {
    ok &= obj.apply()
}

}

if (ok) {
Expand Down
2 changes: 1 addition & 1 deletion src/preferences/qml/MuseScore/Preferences/PreferencesPage.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import Muse.UiComponents

Rectangle {
id: root
height: parent.height
height: parent ? parent.height : 0
color: ui.theme.backgroundSecondaryColor

default property alias contentData: content.data
Expand Down
Loading