Skip to content

Add notehead schemes for pitch names without alterations#34151

Open
ajuncosa wants to merge 1 commit into
musescore:mainfrom
ajuncosa:notehead-schemes
Open

Add notehead schemes for pitch names without alterations#34151
ajuncosa wants to merge 1 commit into
musescore:mainfrom
ajuncosa:notehead-schemes

Conversation

@ajuncosa

Copy link
Copy Markdown
Contributor

Resolves: #34149

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8674c903-43c0-4ed6-a27b-ae793ddeb0bc

📥 Commits

Reviewing files that changed from the base of the PR and between f63b3d1 and 7d60b65.

📒 Files selected for processing (7)
  • src/engraving/dom/note.cpp
  • src/engraving/dom/note.h
  • src/engraving/types/types.h
  • src/engraving/types/typesconv.cpp
  • src/notationscene/widgets/editstafftype.cpp
  • src/propertiespanel/qml/MuseScore/PropertiesPanel/notation/notes/noteheads/noteheadsettingsmodel.cpp
  • src/propertiespanel/qml/MuseScore/PropertiesPanel/notation/stafftype/StaffTypeSettings.qml

📝 Walkthrough

Walkthrough

Adds generic and German pitch-name notehead schemes that omit accidentals. The enum, conversion mappings, staff-type selectors, and properties-panel dropdowns expose the new variants. Notehead rendering now handles German and no-accidentals schemes through shared selection logic, including tpc-based natural, sharp, and flat mappings. The note-name predicate formatting is updated to include the expanded pitch-name scheme conditions, and the headScheme property documentation reflects the added option.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only links the issue and omits the required summary, motivation, and checklist details from the template. Add a short change summary and complete the template checklist, including CLA, testing, commit guidance, and any prior attempts or test artifacts.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding notehead schemes for pitch names without alterations.
Linked Issues check ✅ Passed The changes add no-alteration pitch-name schemes for both standard and German variants and wire them into the UI and notehead logic.
Out of Scope Changes check ✅ Passed The modified files all support the new notehead-scheme feature, with no clear unrelated or unnecessary changes.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ajuncosa ajuncosa requested a review from RomanPudashkin July 10, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add notehead schemes for pitch names without alterations

1 participant