Skip to content

Add libpng to dependencies (required by freetype)#144

Merged
kryksyh merged 1 commit into
musescore:mainfrom
kryksyh:libpng_deps
Jul 10, 2026
Merged

Add libpng to dependencies (required by freetype)#144
kryksyh merged 1 commit into
musescore:mainfrom
kryksyh:libpng_deps

Conversation

@kryksyh

@kryksyh kryksyh commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Resolves: compilation failure on macos

  • I signed the CLA as username:
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.
  • I created a unit test or vtest to verify the changes I made (if applicable).

Build configuration

audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64

@kryksyh kryksyh merged commit dc2e678 into musescore:main Jul 10, 2026
2 of 3 checks passed
@kryksyh kryksyh deleted the libpng_deps branch July 10, 2026 09:46
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2a00bb08-694e-4f12-a28e-3b3454e45001

📥 Commits

Reviewing files that changed from the base of the PR and between a599a97 and 8aa660f.

📒 Files selected for processing (1)
  • buildscripts/cmake/ExtDepsManifest.cmake

📝 Walkthrough

Walkthrough

The CMake dependency manifest now conditionally includes the libpng dependency when MUSE_MODULE_DRAW is enabled.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change to add libpng for freetype on macOS.
Description check ✅ Passed The description mostly matches the template and includes the checklist and build config, though the issue reference is generic and one test checkbox is left unchecked.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants