Skip to content

update deps ref#145

Merged
kryksyh merged 1 commit into
musescore:mainfrom
kryksyh:update_deps_ref
Jul 10, 2026
Merged

update deps ref#145
kryksyh merged 1 commit into
musescore:mainfrom
kryksyh:update_deps_ref

Conversation

@kryksyh

@kryksyh kryksyh commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Resolves: framework UT build

  • I signed the CLA as username:
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.
  • I created a unit test or vtest to verify the changes I made (if applicable).

Build configuration

audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64

@kryksyh kryksyh merged commit 530f940 into musescore:main Jul 10, 2026
2 of 3 checks passed
@kryksyh kryksyh deleted the update_deps_ref branch July 10, 2026 11:52
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updated the stored Muse dependency revision from bcf01b071dc093de6ebe824711180958a230186f to adcefed921921cb090110b4a71a91966c1306889.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The template is present, but the actual description is too vague and missing a concrete issue reference and change motivation. Replace the placeholder text with a real issue/link and a short summary of why the dependency ref was updated.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the dependency reference update in the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@buildscripts/muse_deps.ref`:
- Line 1: Update the uncrustify dependency setup so the muse_deps ref is read,
fetched, and checked out even when EXTDEPS_DIR/buildtools/manifest.cmake already
exists. In tools/codestyle/uncrustify.cmake, keep only initial directory/setup
logic inside the existence guard and move the file(STRINGS), git fetch, and git
checkout operations outside it, matching SetupDependencies.cmake behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b958cbfe-200f-474f-be82-7ff801c256cf

📥 Commits

Reviewing files that changed from the base of the PR and between dc2e678 and ad8523f.

📒 Files selected for processing (1)
  • buildscripts/muse_deps.ref

@@ -1 +1 @@
bcf01b071dc093de6ebe824711180958a230186f No newline at end of file
adcefed921921cb090110b4a71a91966c1306889 No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win

uncrustify.cmake won't pick up this ref update on pre-existing checkouts.

In tools/codestyle/uncrustify.cmake:5-30, the file(STRINGS), git fetch, and git checkout are all inside if(NOT EXISTS "${EXTDEPS_DIR}/buildtools/manifest.cmake"). When the muse_deps directory already exists from a prior build, the new hash is never read or fetched, so the uncrustify toolchain stays on the old revision. In contrast, SetupDependencies.cmake reads and fetches unconditionally, so the main dependencies update correctly — leading to a potential mismatch between the two.

This is a pre-existing issue, but it directly affects whether this ref update takes effect for the uncrustify path. Consider moving the fetch/checkout outside the existence check in uncrustify.cmake to mirror SetupDependencies.cmake's behavior.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@buildscripts/muse_deps.ref` at line 1, Update the uncrustify dependency setup
so the muse_deps ref is read, fetched, and checked out even when
EXTDEPS_DIR/buildtools/manifest.cmake already exists. In
tools/codestyle/uncrustify.cmake, keep only initial directory/setup logic inside
the existence guard and move the file(STRINGS), git fetch, and git checkout
operations outside it, matching SetupDependencies.cmake behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants