update deps ref#145
Conversation
📝 WalkthroughWalkthroughUpdated the stored Muse dependency revision from 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@buildscripts/muse_deps.ref`:
- Line 1: Update the uncrustify dependency setup so the muse_deps ref is read,
fetched, and checked out even when EXTDEPS_DIR/buildtools/manifest.cmake already
exists. In tools/codestyle/uncrustify.cmake, keep only initial directory/setup
logic inside the existence guard and move the file(STRINGS), git fetch, and git
checkout operations outside it, matching SetupDependencies.cmake behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: b958cbfe-200f-474f-be82-7ff801c256cf
📒 Files selected for processing (1)
buildscripts/muse_deps.ref
| @@ -1 +1 @@ | |||
| bcf01b071dc093de6ebe824711180958a230186f No newline at end of file | |||
| adcefed921921cb090110b4a71a91966c1306889 No newline at end of file | |||
There was a problem hiding this comment.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
uncrustify.cmake won't pick up this ref update on pre-existing checkouts.
In tools/codestyle/uncrustify.cmake:5-30, the file(STRINGS), git fetch, and git checkout are all inside if(NOT EXISTS "${EXTDEPS_DIR}/buildtools/manifest.cmake"). When the muse_deps directory already exists from a prior build, the new hash is never read or fetched, so the uncrustify toolchain stays on the old revision. In contrast, SetupDependencies.cmake reads and fetches unconditionally, so the main dependencies update correctly — leading to a potential mismatch between the two.
This is a pre-existing issue, but it directly affects whether this ref update takes effect for the uncrustify path. Consider moving the fetch/checkout outside the existence check in uncrustify.cmake to mirror SetupDependencies.cmake's behavior.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@buildscripts/muse_deps.ref` at line 1, Update the uncrustify dependency setup
so the muse_deps ref is read, fetched, and checked out even when
EXTDEPS_DIR/buildtools/manifest.cmake already exists. In
tools/codestyle/uncrustify.cmake, keep only initial directory/setup logic inside
the existence guard and move the file(STRINGS), git fetch, and git checkout
operations outside it, matching SetupDependencies.cmake behavior.
Resolves: framework UT build
Build configuration
audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64