Fuzzy text search, part 0: Allow subclassing filters and sorters of SortFilterProxyModel#14
Open
juli27 wants to merge 6 commits intomusescore:mainfrom
Open
Fuzzy text search, part 0: Allow subclassing filters and sorters of SortFilterProxyModel#14juli27 wants to merge 6 commits intomusescore:mainfrom
juli27 wants to merge 6 commits intomusescore:mainfrom
Conversation
- Remove unused private method `reset()` - Remove unused invokable method `refresh()` - Remove unused signal `filtersChanged` - it is never emitted - expose roleIdFromName (formerly roleKey) - this is needed by later commits
This prevented multiple filters from using the same role. Also, filter subclasses won't necessarily operate on a single role.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prerequisite part for my effort to implement fuzzy search in MSS. (musescore/MuseScore#15983)
This aligns our
SortFilterProxyModela bit closer to Qt's new-ish Qml SortFilterProxyModel, while allowing custom filters and sorters.MuseScore Studio builds over at the previous home of these changes: musescore/MuseScore#33052.
Build configuration
audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/master
musescore platforms: linux_x64 windows_x64 macos