refactor(deezer): address final review comments

- Move constants to dedicated constants.py module
- Remove hasattr check for raw_episodes (type is known)
- Remove internal-workings docstring lines per MA convention

Author: jdaberkow

music_assistant/providers/deezer/browse.py

@@ -29,7 +29,7 @@
 
 from music_assistant.controllers.cache import use_cache
 
-from .helpers import (
+from .constants import (
     BROWSE_AUDIOBOOKS,
     BROWSE_EXPLORE,
     BROWSE_GENRES,
@@ -52,6 +52,8 @@
     SMART_TRACKLIST_PREFIX,
     TOP_CHARTS_PLAYLIST_ID,
     USER_TOP_TRACKS_PLAYLIST_ID,
+)
+from .helpers import (
     create_virtual_playlist,
 )
 from .parsers import (

music_assistant/providers/deezer/constants.py

@@ -0,0 +1,29 @@
+"""Constants for the Deezer provider."""
+
+# -- Virtual playlist IDs --
+
+FLOW_PLAYLIST_ID = "flow"
+FLOW_CONFIG_PREFIX = "flow_config_"
+SMART_TRACKLIST_PREFIX = "smart_tracklist_"
+RECOMMENDED_TRACKS_PLAYLIST_ID = "recommended_tracks"
+TOP_CHARTS_PLAYLIST_ID = "top_charts"
+USER_TOP_TRACKS_PLAYLIST_ID = "user_top_tracks"
+SHAKER_PREFIX = "shaker_"
+SHAKER_CURATED_PREFIX = "shaker_curated_"
+PERSONAL_SONGS_PLAYLIST_ID = "personal_songs"
+SHAKER_MIX_COVER = "https://cdn-assets.dzcdn.net/shaker/_next/static/media/group_mix.d986951b.svg"
+
+# -- Browse folder names (used as path segments for routing) --
+
+BROWSE_MADE_FOR_YOU = "Made For You"
+BROWSE_EXPLORE = "Explore"
+BROWSE_RECENTLY_PLAYED = "Recently Played"
+BROWSE_SHAKER = "Shaker"
+BROWSE_AUDIOBOOKS = "Discover Audiobooks"
+BROWSE_MOODS = "Moods"
+BROWSE_GENRES = "Genres"
+BROWSE_YOUR_TOP_ARTISTS = "Your Top Artists"
+BROWSE_YOUR_TOP_ALBUMS = "Your Top Albums"
+BROWSE_RECOMMENDED_PLAYLISTS = "Recommended Playlists"
+BROWSE_RECOMMENDED_ARTIST_PLAYLISTS = "Recommended Artist Playlists"
+BROWSE_PERSONALIZED_PLAYLISTS = "Personalized Playlists"

music_assistant/providers/deezer/helpers.py

@@ -18,6 +18,18 @@
     UniqueList,
 )
 
+from .constants import (
+    FLOW_CONFIG_PREFIX,
+    FLOW_PLAYLIST_ID,
+    PERSONAL_SONGS_PLAYLIST_ID,
+    RECOMMENDED_TRACKS_PLAYLIST_ID,
+    SHAKER_CURATED_PREFIX,
+    SHAKER_PREFIX,
+    SMART_TRACKLIST_PREFIX,
+    TOP_CHARTS_PLAYLIST_ID,
+    USER_TOP_TRACKS_PLAYLIST_ID,
+)
+
 if TYPE_CHECKING:
     from deezer_python_gql import DeezerGQLClient
     from deezer_python_gql.generated.get_audiobook import (
@@ -27,34 +39,6 @@
 
     from .provider import DeezerProvider
 
-# -- Virtual playlist IDs --
-
-FLOW_PLAYLIST_ID = "flow"
-FLOW_CONFIG_PREFIX = "flow_config_"
-SMART_TRACKLIST_PREFIX = "smart_tracklist_"
-RECOMMENDED_TRACKS_PLAYLIST_ID = "recommended_tracks"
-TOP_CHARTS_PLAYLIST_ID = "top_charts"
-USER_TOP_TRACKS_PLAYLIST_ID = "user_top_tracks"
-SHAKER_PREFIX = "shaker_"
-SHAKER_CURATED_PREFIX = "shaker_curated_"
-PERSONAL_SONGS_PLAYLIST_ID = "personal_songs"
-SHAKER_MIX_COVER = "https://cdn-assets.dzcdn.net/shaker/_next/static/media/group_mix.d986951b.svg"
-
-# -- Browse folder names (used as path segments for routing) --
-
-BROWSE_MADE_FOR_YOU = "Made For You"
-BROWSE_EXPLORE = "Explore"
-BROWSE_RECENTLY_PLAYED = "Recently Played"
-BROWSE_SHAKER = "Shaker"
-BROWSE_AUDIOBOOKS = "Discover Audiobooks"
-BROWSE_MOODS = "Moods"
-BROWSE_GENRES = "Genres"
-BROWSE_YOUR_TOP_ARTISTS = "Your Top Artists"
-BROWSE_YOUR_TOP_ALBUMS = "Your Top Albums"
-BROWSE_RECOMMENDED_PLAYLISTS = "Recommended Playlists"
-BROWSE_RECOMMENDED_ARTIST_PLAYLISTS = "Recommended Artist Playlists"
-BROWSE_PERSONALIZED_PLAYLISTS = "Personalized Playlists"
-
 
 @dataclass(frozen=True)
 class VirtualPlaylistMeta:

music_assistant/providers/deezer/media.py

@@ -497,8 +497,7 @@ async def get_podcast(self, prov_podcast_id: str) -> Podcast:
         if result is None:
             raise MediaNotFoundError(f"Podcast {prov_podcast_id} not found on Deezer")
         podcast = parse_podcast(self.provider, result)
-        if hasattr(result, "raw_episodes"):
-            podcast.total_episodes = len(result.raw_episodes)
+        podcast.total_episodes = len(result.raw_episodes)
         return podcast
 
     @use_cache(3600 * 24 * 30, allow_expired_cache=True)

music_assistant/providers/deezer/parsers.py

@@ -23,6 +23,7 @@
     GetRecentlyPlayedMeRecentlyPlayedEdgesNodePlaylist,
     GetRecentlyPlayedMeRecentlyPlayedEdgesNodeSmartTracklist,
 )
+from deezer_python_gql.generated.get_track import GetTrackTrack
 from music_assistant_models.enums import (
     AlbumType,
     ExternalID,
@@ -49,10 +50,12 @@
 
 from music_assistant.helpers.util import infer_album_type, parse_title_and_version
 
-from .helpers import (
+from .constants import (
     FLOW_CONFIG_PREFIX,
     FLOW_PLAYLIST_ID,
     SMART_TRACKLIST_PREFIX,
+)
+from .helpers import (
     create_virtual_playlist,
 )
 
@@ -77,7 +80,6 @@
         GetFlowConfigsMeFlowConfigsGenresEdgesNode,
         GetFlowConfigsMeFlowConfigsMoodsEdgesNode,
     )
-    from deezer_python_gql.generated.get_track import GetTrackTrack
     from deezer_python_gql.generated.search import (
         SearchSearchResultsAlbumsEdgesNode,
         SearchSearchResultsArtistsEdgesNode,
@@ -262,7 +264,7 @@ def _parse_track_metadata(
         if img := _cover_image(provider, track.album.cover):
             metadata.add_image(img)
     # Lyrics (only present on GetTrackTrack, not on fragment-based models)
-    if hasattr(track, "lyrics") and track.lyrics is not None:
+    if isinstance(track, GetTrackTrack) and track.lyrics is not None:
         if track.lyrics.text:
             metadata.lyrics = track.lyrics.text
         if track.lyrics.synchronized_lines:
@@ -550,9 +552,6 @@ def parse_audiobook_from_album(
     """
     Create an Audiobook from an AlbumFields result (search context).
 
-    Used when an album search result is identified as an audiobook via
-    check_audiobook_ids. Provides basic metadata from the album fields.
-
     :param provider: The Deezer provider instance.
     :param album: A GQL album model (fragment-based or slim search result).
     """