streams: add DEBUG logging to SmartCrossFade build and fallback paths#3936
Draft
mattamays-ai wants to merge 1 commit into
Draft
streams: add DEBUG logging to SmartCrossFade build and fallback paths#3936mattamays-ai wants to merge 1 commit into
mattamays-ai wants to merge 1 commit into
Conversation
Adds two DEBUG-level log lines to help diagnose smart crossfade behaviour: 1. fades.py — after _build() completes, logs both track BPMs, diff %, bar count, crossfade duration, beat-alignment offset, and whether time-stretch was applied. 2. mixer.py — when falling back to standard crossfade, logs the specific reason (missing BPM, missing beats, no analysis data, etc.) so it is clear in logs why smart crossfade was skipped for a given transition. Validated on nightly build 2.9.0.dev2026052006.
Contributor
|
Can you explain why this is required? We already have extensive verbose logging that you can turn on for smart fades via system > settings > streams > smart fades log level. That should contain all the info needed to debug smart fades related issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two DEBUG-level log lines to help diagnose smart crossfade behaviour:
bar count, crossfade duration, beat-alignment offset, and whether
time-stretch was applied.
reason (missing BPM, missing beats, no analysis data, etc.) so it is
clear in logs why smart crossfade was skipped for a given transition.
Validated on nightly build 2.9.0.dev2026052006.