Skip to content

fix [name, options] syntax for transformers registered as instances #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gigi206 wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −6
Open

fix [name, options] syntax for transformers registered as instances #1390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions packages/core/src/services/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,15 @@ export class ProviderService {
if (Array.isArray(providerConfig.transformer.use)) {
transformer.use = providerConfig.transformer.use.map((transformer) => {
if (Array.isArray(transformer) && typeof transformer[0] === 'string') {
const Constructor = this.transformerService.getTransformer(transformer[0]);
if (Constructor) {
return new (Constructor as TransformerConstructor)(transformer[1]);
const resolved = this.transformerService.getTransformer(transformer[0]);
if (typeof resolved === 'function') {
return new (resolved as TransformerConstructor)(transformer[1]);
}
if (resolved) {
// Transformer was registered as an already-built instance
// (no `static TransformerName`). Re-instantiate via its
// constructor so the requested options take effect.
return new (resolved.constructor as TransformerConstructor)(transformer[1]);
}
}
if (typeof transformer === 'string') {
Expand All @@ -64,9 +70,12 @@ export class ProviderService {
transformer[key] = {
use: providerConfig.transformer[key].use.map((transformer) => {
if (Array.isArray(transformer) && typeof transformer[0] === 'string') {
const Constructor = this.transformerService.getTransformer(transformer[0]);
if (Constructor) {
return new (Constructor as TransformerConstructor)(transformer[1]);
const resolved = this.transformerService.getTransformer(transformer[0]);
if (typeof resolved === 'function') {
return new (resolved as TransformerConstructor)(transformer[1]);
}
if (resolved) {
return new (resolved.constructor as TransformerConstructor)(transformer[1]);
}
}
if (typeof transformer === 'string') {
Expand Down