Update development tools and dependencies#81
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the MCP server’s tool conversion to handle nil tool input schemas by defaulting them to an empty-object JSON schema, and adds a regression test around that behavior.
Changes:
- Default
llm.Tool.InputSchema()fromniltojsonschema.MustFor[struct{}]()during SDK tool conversion. - Add a new test tool and test case intended to verify
nilinput schema handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mcp/server/tool.go | Defaults nil tool input schemas to an empty-object JSON schema before marshalling into the SDK Tool. |
| mcp/server/tool_test.go | Adds a test tool with nil InputSchema and a test case for server tool registration behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of tools with a
nilinput schema in the server code, ensuring they are accepted and default to an empty object schema. It also adds a test to verify this behavior.Input schema handling improvements:
sdkToolFromToolinmcp/server/tool.goto default anynilinput schema to an empty object schema usingjsonschema.MustFor[struct{}](), ensuring all tools have a valid input schema.jsonschemaimport to support the new defaulting behavior.Testing enhancements:
nilInputSchemaTool, and a corresponding test case,TestAddToolsNilInputSchemaDefaultsToEmptyObject, inmcp/server/tool_test.goto verify that tools with anilinput schema are accepted without error.llmimport in the test file to support the new test tool implementation.